[MAINT] remove unused files and makefile recipes#1480
Conversation
Remi-Gau
commented
Mar 11, 2026
Remi-Gau
commented
- relates to files to remove / clean / update #1469
There was a problem hiding this comment.
There was a problem hiding this comment.
travis is not used anymore
There was a problem hiding this comment.
assume this has never been used / updated since creation
|
|
||
| pylint: distclean | ||
| # do distclean first to silence SWIG's sins | ||
| PYTHONPATH=.:$(PYTHONPATH) pylint --rcfile doc/misc/pylintrc nibabel |
There was a problem hiding this comment.
see if the pylint rules ca be run via ruff
There was a problem hiding this comment.
more clean up needed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1480 +/- ##
=======================================
Coverage 95.44% 95.44%
=======================================
Files 209 209
Lines 29981 29981
Branches 4483 4483
=======================================
Hits 28614 28614
Misses 931 931
Partials 436 436 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| upload-html: html-stamp | ||
| ./tools/upload-gh-pages.sh $(WWW_DIR) $(PROJECT) |
There was a problem hiding this comment.
We can probably go ahead and drop this stuff, as well, since it's broken and we're now uploading from GHA.
There was a problem hiding this comment.
not needed anymore AFAICT
| # | ||
| # Building | ||
| # | ||
|
|
||
| all: build | ||
|
|
||
| build: | ||
| $(PYTHON) setup.py config --noisy | ||
| $(PYTHON) setup.py build | ||
|
|
There was a problem hiding this comment.
uses setup.py: remove
| # Does debian version correspond to setup.py version? | ||
| [ "$(DEBCHANGELOG_VERSION)" = "$(SETUPPY_VERSION)" ] | ||
|
|
||
| embed-dev-version: check-nodirty |
There was a problem hiding this comment.
uses setup.py: remove
| deb-mergedev: | ||
| git merge --no-commit origin/dist/debian/dev | ||
|
|
||
| orig-src: distclean distclean |
There was a problem hiding this comment.
uses setup.py: remove
| cd .. && dpkg-source -i'\.(gbp.conf|git\.*)' -b $(CURDIR) | ||
|
|
||
|
|
||
| bdist_rpm: |
There was a problem hiding this comment.
uses setup.py: remove
| source-release: | ||
| uv build --sdist | ||
|
|
||
| venv-tests: |
There was a problem hiding this comment.
uses setup.py: remove
| select = [ | ||
| "B", | ||
| "C4", | ||
| "C90", |
There was a problem hiding this comment.
Would you mind adding a quick description with these? I've started doing this in other projects, and it really helps to not have to look them all up every time. e.g.
| "C90", | |
| "C90", # Whatever this is |
Just ones you're adding, unless you're feeling very motivated.
2 participants
