FIX: Provide FD arguments to combined plot function in BOLD notebook#122
Draft
jhlegarreta wants to merge 1 commit into
Draft
FIX: Provide FD arguments to combined plot function in BOLD notebook#122jhlegarreta wants to merge 1 commit into
jhlegarreta wants to merge 1 commit into
Conversation
Provide FD arguments to combined plot function in BOLD notebook.
Fixes:
```
File "/home/runner/work/nifreeze/nifreeze/docs/notebooks/bold_realignment.py", line 275, in main
plot_combined_profile(
TypeError: main.<locals>.plot_combined_profile() missing 2 required positional arguments: 'afni_fd' and 'nifreeze_fd'
```
raised for example in:
https://github.com/nipreps/nifreeze/actions/runs/15007162520/job/42168515561?pr=117#step:14:2223
Take advantage of the commit to rename the function definition variables
so that they do not shadow the outer variables.
jhlegarreta
force-pushed
the
FixCombinedProfileCallInBOLDNotebook
branch
from
d3e2608 to
b4e47b7
Compare
oesteban
reviewed
May 15, 2025
Comment on lines
+301
to
+302
| " afni_fd,\n", | ||
| " nifreeze_fd,\n", |
Member
There was a problem hiding this comment.
These are not ever calculated explicitly. It does look like some cell is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide FD arguments to combined plot function in BOLD notebook.
Fixes:
raised for example in:
https://github.com/nipreps/nifreeze/actions/runs/15007162520/job/42168515561?pr=117#step:14:2223
Take advantage of the commit to rename the function definition variables so that they do not shadow the outer variables.