This repository was archived by the owner on Jan 27, 2025. It is now read-only.
ENH: Add gradient encoding direction angle computation utils#200
Merged
Conversation
Collaborator
Author
|
Need to go through #188 (comment) and incorporate jhlegarreta#1. |
arokem
reviewed
May 27, 2024
esavary
reviewed
May 27, 2024
esavary
reviewed
May 27, 2024
jhlegarreta
force-pushed
the
AddGradAngleComputationUtils
branch
2 times, most recently
from
759a5a2 to
9c956bc
Compare
Collaborator
Author
|
Went over @yibeichan's related #188 (comment). For now, assuming it is an ndarray, so no need for the checks. |
jhlegarreta
force-pushed
the
AddGradAngleComputationUtils
branch
3 times, most recently
from
98edd37 to
d0e6a70
Compare
jhlegarreta
force-pushed
the
AddGradAngleComputationUtils
branch
5 times, most recently
from
dffd7e5 to
c39aeb5
Compare
Collaborator
Author
|
@oesteban ready to be merged. |
Collaborator
Author
|
@esavary would be great if you could have a quick look. Thanks. |
esavary
previously approved these changes
May 29, 2024
Member
I made a few comments on your questions inside the code, but it looks ready to merge to me. |
oesteban
reviewed
May 30, 2024
jhlegarreta
force-pushed
the
AddGradAngleComputationUtils
branch
from
c39aeb5 to
95aa6b0
Compare
oesteban
reviewed
May 31, 2024
jhlegarreta
force-pushed
the
AddGradAngleComputationUtils
branch
from
95aa6b0 to
7446b59
Compare
Collaborator
Author
|
Left the v1, v2 angle computation method in case we need it. I'd merged this as is so that we can see with Elodie if we manage to use the index-based loo framework. |
oesteban
previously approved these changes
Jun 3, 2024
oesteban
left a comment
oesteban
left a comment
Member
There was a problem hiding this comment.
Suggesting some doctests, otherwise looks good!
jhlegarreta
force-pushed
the
AddGradAngleComputationUtils
branch
from
7446b59 to
f473a40
Compare
Add gradient encoding direction angle computation utils: compute pairwise angles across gradient encoding directions. Add the corresponding test. Add the corresponding entry to the doc toctree.
Use appropriate object in numpy array parameter docstring.
jhlegarreta
force-pushed
the
AddGradAngleComputationUtils
branch
from
f473a40 to
61c2200
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add gradient encoding direction angle computation utils: compute pairwise angles across gradient encoding directions.
Add the corresponding test.