Repository navigation
Conversation
In zip_close(), survivors is a 64-bit integer (zip_uint64_t). On 32-bit platforms, the allocation size calculation sizeof(filelist[0]) * (size_t)survivors could overflow size_t when survivors exceeds SIZE_MAX / sizeof(filelist[0]), leading to an undersized buffer allocation and subsequent out-of-bounds writes. Additionally: - When survivors == 0 (e.g. keeping an empty archive), avoid calling malloc(0), which may return NULL on some platforms/allocators and cause spurious failure. - Ensure zip_error_set(&za->error, ZIP_ER_MEMORY, 0) is called if allocation fails so callers receive a consistent error code. - Guard the qsort() call to avoid passing a NULL pointer when survivors == 0.
Member
|
Thanks. The overflow can't happen because we already check that survivors < za->nentry. We applied NULL pointer handling change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In zip_close(), survivors is a 64-bit integer (zip_uint64_t).