Conversation
…tzip archives zip_file_extra_field_delete_by_id() and zip_file_extra_field_set() reject modifications to extra fields when ZIP_WANT_TORRENTZIP(za) is set, returning -1 with ZIP_ER_NOT_ALLOWED. zip_file_extra_field_delete() was missing this check, allowing callers to delete extra fields from archives being converted to torrentzip. Add the ZIP_WANT_TORRENTZIP check to match sibling extra field functions.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zip_file_extra_field_delete_by_id()andzip_file_extra_field_set()reject modifications to extra fields whenZIP_WANT_TORRENTZIP(za)is set, returning-1withZIP_ER_NOT_ALLOWED.zip_file_extra_field_delete()was missing this check, allowing callers to delete extra fields from archives being converted to torrentzip. This patch adds theZIP_WANT_TORRENTZIPcheck to match sibling extra field functions.