Events count fix#172
Open
gaffel85 wants to merge 1 commit into
Open
Conversation
shoudlPromptForRating did stop checking events count when uses count did reach its goal. By changing AND to OR both expression will be checked.
Owner
|
This isn't actually a bug, but a design decision. Arguably it was a bad decision, but applying this fix as it stands actually breaks the default functionality, since usesUntilPrompt defaults to 10, so any app that doesn't log any events will never present the notification. If you want to prevent notifications unless both use count AND event count have been reached, you can add this additional check using the iRate delegate. |
Owner
|
I'll leave this open for now - I may consider changing this behaviour at some point but it will need some other changes to be made as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shoudlPromptForRating did stop checking events count when uses count did reach its goal.
By changing AND to OR both expression will be checked.