Don't connect the Internet every time app starts or enters foreground#169
Open
techee wants to merge 1 commit into
Open
Don't connect the Internet every time app starts or enters foreground#169techee wants to merge 1 commit into
techee wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My app
https://itunes.apple.com/us/app/system-status-activity-monitor/id401457165?mt=8
shows the list of active network connections as one of its features. I've noticed that recently lots of connections started appearing after the app starts. It turns out iRate connects the internet every time the app is started or enters foreground.
After git blame, I got to this commit:
Updated to version 1.8.1
d3bc941
which contains quite a lot of changes but from the release notes, only this item seems to be relevant:
In my opinion the connectivity check shouldn't be there because it's checked in promptIfNetworkAvailable three lines after but only when needed. But take this as a patch from a guy who doesn't know what he's doing and maybe it breaks other things. Please check.