build_module.sh hardening & CI

[thresheek]

Proposed changes

This PR attempts to make build_module.sh less of a mess and adds (some) CI to make sure it's not broken.

[Copilot]

Pull request overview

This PR hardens build_module.sh to be safer and more robust (quoting, temp-dir handling, URL download retries, better errors) and introduces a GitHub Actions workflow to exercise the script in CI across a small OS/NGINX flavor matrix.

Changes:

• Hardened build_module.sh with better quoting, safer temp directory creation, and clearer error handling around git/dir operations.
• Added a retrying URL download helper and basic archive path-safety checks for zip/tar sources.
• Added a new GitHub Actions workflow to run build_module.sh in containers for OSS and Plus builds.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 10 comments.

File	Description
build_module.sh	Refactors/hardens argument handling, downloading, temp build dir creation, and packaging artifact collection.
.github/workflows/build-module.yml	Adds CI job to build a sample module across OS/flavor combinations.

Comments suppressed due to low confidence (1)

build_module.sh:130

• The -v flag allows an optional OSS version, but the minimum-version check runs even when no version was provided. With -v <module_source> (no explicit version), OSS_VER remains unset/empty and the comparison treats it as less than 1.11.5, causing an unconditional error. Gate the version comparison behind a non-empty OSS_VER (or set a safe default) so -v without an explicit version works as intended.

			if [ `printf '%s' ".$2" | tr -d '[0-9\.]' | wc -c` -eq 0 ]; then
				OSS_VER=$2
				shift
			fi
			if [ `echo "1.11.4^$OSS_VER" | tr '^' '\n' | tr '.' ',' | sort -nr | head -1` = "1,11,4" ]; then

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[oxpa]

jftr: the whole approach "lets find some package managers" doesn't work that well. It seems like most modern OS use /etc/os-release which we can source, find ID and use that to determine the package manager.

[oxpa]

I don't quite get the benefit of "printf "%s" over "echo -n" though. But looks good anyways.