Skip to content

Address v3.0.0 release review comments from #192

Merged
jfy133 merged 4 commits into
devfrom
v3-diego-comments
Apr 30, 2026
Merged

Address v3.0.0 release review comments from #192
jfy133 merged 4 commits into
devfrom
v3-diego-comments

Conversation

@jfy133
Copy link
Copy Markdown
Member

@jfy133 jfy133 commented Apr 30, 2026

Thanks @dialvarezs !

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/createtaxdb branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2026

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit c0ddc56

+| ✅ 236 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   2 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 3.0.0
  • pipeline_todos - TODO string in CONTRIBUTING.md: Add any pipeline specific contribution guidelines here, such as coding styles, procedures, checklists etc.

❔ Tests ignored:

  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.1
  • Run at 2026-04-30 09:07:58

Copy link
Copy Markdown
Member

@dialvarezs dialvarezs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👌

@jfy133 jfy133 merged commit 069ab36 into dev Apr 30, 2026
20 of 22 checks passed
@jfy133 jfy133 deleted the v3-diego-comments branch April 30, 2026 09:11
@jfy133
Copy link
Copy Markdown
Member Author

jfy133 commented Apr 30, 2026

Thank you @dialvarezs !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants