fix: add disconnect confirmation dialog to both desktop and web channel pages#1183
fix: add disconnect confirmation dialog to both desktop and web channel pages#1183jaimax0401 wants to merge 1 commit into
Conversation
lefarcen
added
size/M
lefarcen
left a comment
lefarcen
left a comment
There was a problem hiding this comment.
Hi @jaimax0401, thanks for carrying the feedback from #1182 into both surfaces. The desktop modal now follows the existing cloud-profile styling, and the web flow is moving in the right direction too. I found one user-visible blocker in the web copy plus a small cleanup item — once those are addressed, this should be much closer to landing.
| </div> | ||
| <div> | ||
| <h3 className="text-[14px] font-semibold text-text-primary"> | ||
| {t("channels.confirmDisconnect")} |
There was a problem hiding this comment.
P1 These new channels.confirmDisconnect* translation keys are not added to apps/web/src/i18n/locales/en.ts or zh-CN.ts, so i18next will render the raw key names in the confirmation dialog. Please add confirmDisconnect, confirmDisconnectDesc, and confirmDisconnectBody to both locale files, or reuse the existing reset keys if the copy should stay identical.
| track("workspace_channel_disconnect_click", { | ||
| channel: platform, | ||
| }); | ||
| disconnectChannelId; // capture before clearing |
There was a problem hiding this comment.
P2 This standalone disconnectChannelId; expression does not capture anything and is likely to trip lint/reader confusion. Either remove it and call the mutation directly, or actually pass the stored id through the mutation if the confirmation modal is meant to bind to that specific channel.
… all locales (#1140) - Replace feishu-contributor-qr.png with the new nexu core contributor group QR - Add Feishu group invite link alongside Discord in en/ja/ko contributor docs - Chinese docs already had the QR image, now updated via the replaced file Made-with: Cursor Co-authored-by: caiqiling958-cmd <>
jaimax0401
force-pushed
the
fix/channel-disconnect-confirmation
branch
from
d9c7c2e to
a8addc4
Compare
lefarcen
added
size/XL
lefarcen
left a comment
lefarcen
left a comment
There was a problem hiding this comment.
Hey @jaimax0401, thanks for the quick follow-up. The web dialog cleanup from the last pass is partly addressed, and the extra Chinese locale entries are in the right place. I still need to keep this blocked, though: the English locale currently breaks the module, and this push also brought in a large scheduled community-content workflow that is outside the disconnect-confirmation fix and needs to be split/reviewed separately.
| } as const; | ||
|
|
||
| export default en; | ||
| "channels.confirmDisconnect": "Confirm disconnect", |
There was a problem hiding this comment.
P1 These keys were appended after export default en, outside the en object, so this file is syntactically invalid and the web build will fail. Move the channels.confirmDisconnect* entries up into the const en = { ... } object next to the existing channels.confirmReset* keys, before the closing } as const;.
| @@ -0,0 +1,59 @@ | |||
| name: Community Content Push | |||
There was a problem hiding this comment.
P1 This new scheduled workflow is unrelated to the disconnect-confirmation bugfix and would start production cron pushes to Feishu/Discord using repo secrets and an LLM. Please remove the community-content workflow/script/docs/QR changes from this PR and split them into a separate PR with the right product/security review context.
3 participants
Description
Fixes the missing secondary confirmation dialog when disconnecting a channel. Addresses review feedback from PR #1182:
Changes
apps/desktop/src/pages/cloud-profile-page.tsx: Refactored to use CSS classes matching the existing modal patternapps/desktop/src/runtime-page.css: Added .cloud-profile-modal-desc styleapps/web/src/pages/channels.tsx: Added disconnectChannelId state + confirmation modalTesting
Manual:
Fixes #1063