Skip to content

fix: Add comments that homepath is trusted #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlSchwan merged 1 commit into from
May 29, 2026
+10 −4
Merged

fix: Add comments that homepath is trusted #1119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/UserBackend.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,22 @@ public function createUserIfNotExists(string $uid, array $attributes = []): void
}

if ($home !== '') {
//if attribute's value is an absolute path take this, otherwise append it to data dir
//check for / at the beginning or pattern c:\ resp. c:/
$dataDir = $this->config->getSystemValueString('datadirectory', $this->serverRoot . '/data');

// note: Path traversal is allowed because we trust the idp and it allows to do partitioning
// of the storage.
//
// If attribute's value is an absolute path take this, otherwise append it to data dir
// check for / at the beginning or pattern c:\ resp. c:/
if ($home[0] !== '/'
&& !(strlen($home) > 3 && ctype_alpha($home[0])
&& $home[1] === ':' && ($home[2] === '\\' || $home[2] === '/'))
) {
$home = $this->config->getSystemValueString('datadirectory',
$this->serverRoot . '/data') . '/' . $home;
$home = $dataDir . '/' . $home;
}
}

if ($home !== '') {
$values['home'] = $home;
}

Expand Down
Loading