Skip to content

fix: Make sure getMetadata is accessible #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarlSchwan merged 2 commits into from
Apr 30, 2026
Merged

fix: Make sure getMetadata is accessible #1097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0e2f9b
fix: Make sure getMetadata is accessible
CarlSchwan Apr 30, 2026
f63a71e
fix: Stronger check that metadata response is valid
CarlSchwan Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions lib/Controller/SAMLController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,6 @@ public function login(int $idp = 1): Http\RedirectResponse|Http\TemplateResponse
*/
#[PublicPage]
#[NoCSRFRequired]
#[OnlyUnauthenticatedUsers]
public function getMetadata(int $idp = 1): Http\DataDownloadResponse {
$settings = new Settings($this->samlSettings->getOneLoginSettingsArray($idp));
$metadata = $settings->getSPMetadata();
Expand All @@ -305,8 +304,6 @@ public function getMetadata(int $idp = 1): Http\DataDownloadResponse {

/**
* @NoSameSiteCookieRequired
*
* @return Http\RedirectResponse
* @throws Error
* @throws ValidationError
*/
Expand Down
8 changes: 5 additions & 3 deletions src/components/ProviderSettingsDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,9 +445,11 @@ function onOpenChanged(open: boolean): void {
*/
async function testMetaData(): Promise<void> {
try {
await axios.get(generateUrl(`/apps/user_saml/saml/metadata?idp=${props.provider.id}`))
metadataValid.value = true
} catch {
const { data, headers } = await axios.get(generateUrl(`/apps/user_saml/saml/metadata?idp=${props.provider.id}`))
const parser = new DOMParser()
const xml = parser.parseFromString(data, "application/xml")
metadataValid.value = headers["content-type"] === 'text/xml;charset=UTF-8' && xml.documentElement.localName === 'EntityDescriptor'
} catch (e) {
metadataValid.value = false
}
}
Expand Down
Loading