Skip to content

fix: Avoid redirecting to login with an incomplete configuration#1091

Merged
come-nc merged 1 commit into
masterfrom
fix/avoid-crash-with-incomplete-configuration
Apr 30, 2026
Merged

fix: Avoid redirecting to login with an incomplete configuration#1091
come-nc merged 1 commit into
masterfrom
fix/avoid-crash-with-incomplete-configuration

Conversation

@come-nc

@come-nc come-nc commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

@CarlSchwan CarlSchwan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

psalm need a bit of fixing but looks good

@CarlSchwan CarlSchwan added this to the 8.0.1 milestone Apr 30, 2026
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc force-pushed the fix/avoid-crash-with-incomplete-configuration branch from 53c26b1 to 3c2857e Compare April 30, 2026 12:25
@come-nc come-nc enabled auto-merge April 30, 2026 12:28
@come-nc come-nc merged commit 3a806f8 into master Apr 30, 2026
57 checks passed
@come-nc come-nc deleted the fix/avoid-crash-with-incomplete-configuration branch April 30, 2026 12:41
@artonge

artonge commented May 5, 2026

Copy link
Copy Markdown
Contributor

/backport to stable7

@backportbot

backportbot Bot commented May 5, 2026

Copy link
Copy Markdown

The backport to stable7 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable7
git pull origin stable7

# Create the new backport branch
git checkout -b backport/1091/stable7

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3c2857e2

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1091/stable7

Error: Failed to clone repository: Failed to create working tree: Preparing worktree (new branch 'backport/1091/stable7')
fatal: not a valid object name: 'origin/stable7'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@blizzz

blizzz commented May 5, 2026

Copy link
Copy Markdown
Member

/backport to stable-7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle incomplete saml configuration more gracefully

4 participants