Add "Mark as read" action to chat notifications

[jancborchardt]

Currently the notifications only have the primary "View chat" and the default "Dismiss" x. A very useful addition would be a secondary "Mark as read" button which directly marks the message as read and removes the notification.

☑️ Resolves

• Fix "Mark as read" action for Talk notifications #6035

AI (if applicable)

• The content of this PR was partly or fully generated using AI

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before	🏡 After

🏁 Checklist

• 🌏 Tested with different browsers / clients:
  • Chromium (Chrome / Edge / Opera / Brave)
  • Firefox
  • Safari
  • Talk Desktop
  • Integrations with Files sidebar and other apps
  • Not risky to browser differences / client
• 🖌️ Design was reviewed, approved or inspired by the design team
• ⛑️ Tests are included or not possible: Notifications are not covered by tests yet at all so I didn’t want to start with smth potentially wrong
• 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

[nickvergessen]

A very useful addition would be a secondary "Mark as read" button which directly marks the message as read and removes the notification.

I think this is dangerous. Maybe it works in some chats, but there are 2 cases where this has unintended side effects:

1. If you got top to bottom through your notifications, marking a higher one as read, will discard all other chat notifications in the same chat as the read-marker was placed behind them
2. If you had further unread messages that did not trigger a chat notification due to your selected notification level, you will never be aware of that.

Both indications are very much not clear from the label on the button.
I'm fine adding the button, if it is just a shortcut to dismiss. But in the current state I think this can hurt conversations

[Antreesy]

... this has unintended side effects

Agree, read marker logic is already quite fragile to mess with it from backend side

if it is just a shortcut to dismiss

Then why not have a 'Dismiss' button here... I feel like this place better stay reserved for potential 'Quick reply' feature, although that would need more intervention from 'notifications' apps side. Short reply would then post a message linking to origin one and reset the read marker that way

[jancborchardt]

1. If you got top to bottom through your notifications, marking a higher one as read, will discard all other chat notifications in the same chat as the read-marker was placed behind them

Right, this is a side-effect of our implementation.

2. If you had further unread messages that did not trigger a chat notification due to your selected notification level, you will never be aware of that.

This also seems dependent on our implementation of a "read marker". If we would just mark the specific mention as "read", the other unread messages would still show and you would still be aware.

I'm fine adding the button, if it is just a shortcut to dismiss.

But dismissing is already possible via the x. I don’t only want to dismiss the notification though. Especially for simple 👍 reactions or things I just take in but don’t need to reply to I would like to mark them as read (which is why I opened the issue back then too).

---

I feel like this place better stay reserved for potential 'Quick reply' feature, although that would need more intervention from 'notifications' apps side. Short reply would then post a message linking to origin one and reset the read marker that way

@Antreesy I actually think "View chat" would be better to get replaced with "Reply". That is how it’s usually done in mobile apps, for the 3 different levels of handling the message:

• Tapping on the notification opens the chat: If you need to act more on it
• "Reply": For a quick reply
• "Mark as read": If you only need to acknowledge it but not act on it further

[nickvergessen]

"Mark as read": If you only need to acknowledge it but not act on it further

I just checked, that is true for Whatsapp, Threema and all, but they all show always all the messages in the notifications combined on a per chat level.
Since it's currently breaking behaviour, I would then tend to close it, until we had time to refactor notifications to support this fully (showing notifications grouped by the object and across all pages, etc)

[jancborchardt]

Talk Android for example also shows Reply and Mark as read though, does that use different logic?