refactor(image): modernize GD image helper and fix minor handling inconsistencies#61637
Draft
joshtrichards wants to merge 1 commit into
Draft
refactor(image): modernize GD image helper and fix minor handling inconsistencies#61637joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
This was referenced Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernize
OC\Imageand simplify several code paths in the GD-backed image helper.Alongside the cleanup, this also fixes a few minor behavioral inconsistencies in image loading/output and EXIF orientation handling.
Changes:
matchexpressions where they improve readabilityOCP\IImageinterfaceMinor fixes included:
This is primarily a refactor/cleanup of the existing image helper and does not change its overall responsibilities or public behavior beyond the minor fixes above.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)