Skip to content

fix(a11y): label account QR code button#61600

Merged
AndyScherzinger merged 2 commits into
masterfrom
fix/60292/a11y-header-buttons
Jun 25, 2026
Merged

fix(a11y): label account QR code button#61600
AndyScherzinger merged 2 commits into
masterfrom
fix/60292/a11y-header-buttons

Conversation

@AndyScherzinger

@AndyScherzinger AndyScherzinger commented Jun 25, 2026

Copy link
Copy Markdown
Member

Summary

local version of #60616 for CI runs and merge

Summary

  • Add an accessible label to the account menu QR code icon-only button.
  • Add coverage for the QR code button accessible name.
  • Add coverage that the app menu trigger buttons expose accessible labels.

Fixes #60292

Tests

  • npx vitest run --project nextcloud-ui-legacy core/src/tests/components/AccountMenuProfileEntry.spec.ts core/src/tests/components/AppMenu.spec.ts
  • npm run lint
  • git diff --check origin/master...HEAD

Validated in a clean Docker container from a fresh nextcloud/server clone using node:24-bookworm.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Francisco Silva <116388885+Will-thom@users.noreply.github.com>
@AndyScherzinger AndyScherzinger added this to the Nextcloud 35 milestone Jun 25, 2026
@AndyScherzinger AndyScherzinger requested a review from a team as a code owner June 25, 2026 17:13
@AndyScherzinger AndyScherzinger added 4. to release Ready to be released and/or waiting for tests to finish community pull requests from community labels Jun 25, 2026
@AndyScherzinger AndyScherzinger requested review from nfebe, sorbaugh and susnux and removed request for a team June 25, 2026 17:13
@AndyScherzinger

Copy link
Copy Markdown
Member Author

/backport to stable34

@AndyScherzinger

Copy link
Copy Markdown
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@AndyScherzinger AndyScherzinger merged commit de4c342 into master Jun 25, 2026
192 of 195 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/60292/a11y-header-buttons branch June 25, 2026 18:11
@AndyScherzinger

Copy link
Copy Markdown
Member Author

/backport to stable33

@backportbot

backportbot Bot commented Jun 25, 2026

Copy link
Copy Markdown

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/61600/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 21adba71 bc58afec

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/61600/stable33

Error: Failed to check for changes with origin/stable33: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@susnux

susnux commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

local version of #60616 for CI runs and merge

Should not be needed anymore any CI now works also on forks :)

@AndyScherzinger

Copy link
Copy Markdown
Member Author

Neat, that I didn't know, but happy to hear 🎉

@AndyScherzinger

Copy link
Copy Markdown
Member Author

/backport to stable33

@backportbot

backportbot Bot commented Jun 25, 2026

Copy link
Copy Markdown

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/61600/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 21adba71 bc58afec

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/61600/stable33

Error: Failed to check for changes with origin/stable33: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish accessibility backport-request community pull requests from community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NcButton accessibility warning fires twice on every logged-in page load (UserMenu, MainMenu)

4 participants