refactor(app): finalize app upgrade state before queueing follow-up jobs#61536
Draft
joshtrichards wants to merge 1 commit into
Draft
refactor(app): finalize app upgrade state before queueing follow-up jobs#61536joshtrichards wants to merge 1 commit into
joshtrichards wants to merge 1 commit into
Conversation
joshtrichards
changed the title
joshtrichards
commented
Jun 23, 2026
Comment on lines
1122
to
1123
| $this->clearAppsCache(); | ||
| $this->getAppVersion($appId, false); |
Member
Author
There was a problem hiding this comment.
I don't believe these are necessary, but not being certain I left as-is.
Side note: clearAppsCache() is a bit of a misleading name since it doesn't cover all cached bits.
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
force-pushed
the
jtr/appManager-upgrade-ordering
branch
from
1aa28b4 to
a2ef58c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adjusts the app upgrade flow in
AppManagerso that app metadata, config lexicon updates, and theinstalled_versionare finalized before live-migration and background jobs are queued.This avoids scheduling background repair work while the app is still in an intermediate upgrade state and makes the upgrade sequence more consistent and safer.
With this ordering,
installed_versionmore accurately reflects that synchronous upgrade work completed successfully, and deferred work is clearly treated as follow-up.TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)