Fix tar type detection for hidden archives#61279
Open
fwerkor wants to merge 2 commits into
Open
Conversation
fwerkor
requested review from
Altahrim,
ArtificialOwl,
leftybournes and
salmart-dev
and removed request for
a team
Signed-off-by: Yuhang Cao <caoyuhang@fwerkor.com>
fwerkor
force-pushed
the
fix/tar-hidden-archives
branch
from
7f56b01 to
5fe2d90
Compare
fwerkor
force-pushed
the
fix/tar-hidden-archives
branch
from
b69c0ae to
5fe2d90
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix TAR type detection for hidden compressed archive names. The previous dot check treated a leading dot as no extension, so
.tar.gz,.tgz, and.tar.bz2fell back to plain tar handling.TODO
Checklist
Tests
../vendor-bin/phpunit/vendor/bin/phpunit -c phpunit-autotest.xml lib/Archive/TARTest.php --filter '/test.*/'php --syntax-check lib/private/Archive/TAR.phpphp --syntax-check tests/lib/Archive/TARTest.phpAI (if applicable)