Conversation
susnux
requested review from
Altahrim,
artonge,
nickvergessen,
provokateurin and
sorbaugh
susnux
added
2. developing
artonge
approved these changes
Jun 12, 2026
susnux
commented
Jun 12, 2026
|
|
||
| mysql: | ||
| image: ghcr.io/nextcloud/continuous-integration-mysql-${{ matrix.mysql-versions }}:latest # zizmor: ignore[unpinned-images] | ||
| image: mysql:${{ matrix.mysql-versions }} # zizmor: ignore[unpinned-images] |
Contributor
Author
There was a problem hiding this comment.
@nickvergessen as we now have a docker cache in place we do not run into problems with docker hub anymore. Do we still need to use our own images?
If yes I will prepare the new image.
Member
There was a problem hiding this comment.
Is it more likely that we get hacked or mysql? :P
I guess both is fine
susnux
added
3. to review
CarlSchwan
approved these changes
Jun 18, 2026
susnux
force-pushed
the
fix/mysql
branch
5 times, most recently
from
c06876a to
26e389f
Compare
- Version 8.0 is out-of-support. - Version 8.4 is now the oldest LTS. - New LTS is 9.7 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
added
4. to release
4 tasks
susnux
removed
the
pending documentation
| echo "SET GLOBAL sql_mode=(SELECT CONCAT(@@sql_mode,',ONLY_FULL_GROUP_BY'));" | mysql -h 127.0.0.1 -P 4444 -u root -prootpassword | ||
| echo "SELECT @@sql_mode;" | mysql -h 127.0.0.1 -P 4444 -u root -prootpassword | ||
|
|
||
| - name: Enable MD5 MySQL support |
Member
There was a problem hiding this comment.
PS: Is this only needed in sharding? Or should it also be in phpunit-mysql?
And I guess we should change https://github.com/nextcloud/.github/blob/master/workflow-templates/phpunit-mysql.yml as well so apps start testing against it
Contributor
Author
There was a problem hiding this comment.
Only needed in sharding, for non sharded setup the installer will handle this.
But for sharded setup it needs to be done manually per shard.
For apps they should setup a fresh server, no? Because then the installer takes care of this.
3 tasks
susnux
commented
Jun 26, 2026
Comment on lines
+41
to
+61
| // for MD5 support | ||
| // In MySQL 9+ MD5 has been deprecated and is only available as a component. | ||
| // Until we dropped the support for it on the function builder, we need to load the component. | ||
| if ($connection->getDatabasePlatform() instanceof MySQL84Platform) { | ||
| $statement = $connection->prepare("SHOW VARIABLES LIKE 'version';"); | ||
| $result = $statement->executeQuery(); | ||
| $row = $result->fetchAssociative(); | ||
| $version = $row['Value']; | ||
| [$major, ] = explode('.', strtolower($version)); | ||
| if ((int)$major >= 9) { | ||
| // check if the component is already loaded, if not load it | ||
| $statement = $connection->prepare("SELECT COUNT(*) FROM mysql.component WHERE component_urn = 'file://component_classic_hashing';"); | ||
| $result = $statement->executeQuery(); | ||
| $count = $result->fetchOne(); | ||
| if ($count !== false && (int)$count === 0) { | ||
| // not yet loaded | ||
| $statement = $connection->prepare("INSTALL COMPONENT 'file://component_classic_hashing';"); | ||
| $statement->executeStatement(); | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
documentation: nextcloud/documentation#15200
Checklist
3. to review, feature component)stable32)AI (if applicable)