perf(mounts): Replace many array_ by a simple loop#58275
Open
CarlSchwan wants to merge 1 commit into
Open
Conversation
CarlSchwan
force-pushed
the
carl/loop-root
branch
2 times, most recently
from
18e3e31 to
82664e1
Compare
CarlSchwan
requested review from
artonge,
icewind1991,
leftybournes,
salmart-dev and
sorbaugh
and removed request for
a team
CarlSchwan
force-pushed
the
carl/loop-root
branch
2 times, most recently
from
e6bb2b3 to
304adf5
Compare
CarlSchwan
force-pushed
the
carl/loop-root
branch
from
304adf5 to
e84f7c1
Compare
come-nc
requested changes
Jun 23, 2026
CarlSchwan
force-pushed
the
carl/loop-root
branch
from
e84f7c1 to
fcbc9dc
Compare
And allow to abort once we found a node when getFirstNodeById is called. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/loop-root
branch
from
fcbc9dc to
f20a964
Compare
come-nc
reviewed
Jun 23, 2026
come-nc
left a comment
come-nc
left a comment
Contributor
There was a problem hiding this comment.
The sorting thing is weird. This may reopen previously closed issues by #28220
It’s not clear to me if the sorting on mountpoint is enough to always get the same order and if that’s all we care about or if that will cause trouble.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And allow to abort once we found a node when getFirstNodeById is called.
Note that now the sorting is done on the mountpoints instead of the node path, this has some behavior changes and I am not sure if this is 100% correct. See modified test.
Summary
TODO
Checklist
3. to review, feature component)stable32)