refactor(QueryBuilder): Properly type the query builder#57763
Open
CarlSchwan wants to merge 2 commits into
Open
refactor(QueryBuilder): Properly type the query builder#57763CarlSchwan wants to merge 2 commits into
CarlSchwan wants to merge 2 commits into
Conversation
CarlSchwan
added
2. developing
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
CarlSchwan
force-pushed
the
carl/type-querybuilder
branch
7 times, most recently
from
4949aa8 to
27c24e9
Compare
CarlSchwan
force-pushed
the
carl/type-querybuilder
branch
2 times, most recently
from
75af4a1 to
ca05129
Compare
CarlSchwan
added
3. to review
CarlSchwan
requested review from
a team,
SebastianKrupinski and
hamza221
as code owners
CarlSchwan
requested review from
Altahrim,
ArtificialOwl,
icewind1991 and
sorbaugh
and removed request for
a team
come-nc
reviewed
Jan 27, 2026
CarlSchwan
force-pushed
the
carl/type-querybuilder
branch
3 times, most recently
from
efaca86 to
4020f91
Compare
provokateurin
requested changes
Feb 17, 2026
provokateurin
left a comment
provokateurin
left a comment
Member
There was a problem hiding this comment.
Please add all files you touched to psalm:strict and rector:strict. That will probably result in some more issues being found, but I think it's worth fixing them in such an important part of our codebase.
CarlSchwan
force-pushed
the
carl/type-querybuilder
branch
from
4020f91 to
5c85223
Compare
Merged
Closed
And make sure the related unit tests are also typed and checked by psalm. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/type-querybuilder
branch
from
5c85223 to
d5b81a1
Compare
CarlSchwan
force-pushed
the
carl/type-querybuilder
branch
from
d5b81a1 to
bbaf603
Compare
And put the files in rector strict and psalm strict Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwan
force-pushed
the
carl/type-querybuilder
branch
from
bbaf603 to
fa0d136
Compare
7 tasks
come-nc
approved these changes
Jun 23, 2026
| * SPDX-License-Identifier: AGPL-3.0-only | ||
| */ | ||
|
|
||
| declare(strict_types=1); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)