Skip to content

perf(base): Stop setting up the FS for every basic auth request#54803

Open
provokateurin wants to merge 4 commits into
masterfrom
perf/base/basic-auth-fs-setup
Open

perf(base): Stop setting up the FS for every basic auth request#54803
provokateurin wants to merge 4 commits into
masterfrom
perf/base/basic-auth-fs-setup

Conversation

@provokateurin

@provokateurin provokateurin commented Sep 2, 2025

Copy link
Copy Markdown
Member

One more time, we're gonna celebrate 🎵 ✌️ (last time, I promise 🤞)

Needs nextcloud/guests#1400 to not break the Guests app.
Nothing needed to change on the server side, it's the exact same changes as with the last PR.

@provokateurin provokateurin added this to the Nextcloud 33 milestone Sep 2, 2025
@provokateurin provokateurin requested review from a team as code owners September 2, 2025 12:12
@provokateurin provokateurin requested review from nfebe, sorbaugh, susnux, szaimen and yemkareems and removed request for a team September 2, 2025 12:12
@provokateurin

Copy link
Copy Markdown
Member Author

/compile

@nickvergessen

nickvergessen commented Sep 2, 2025

Copy link
Copy Markdown
Member

@provokateurin

Copy link
Copy Markdown
Member Author

@provokateurin provokateurin marked this pull request as draft September 2, 2025 16:27
@szaimen szaimen requested review from come-nc and skjnldsv and removed request for szaimen September 3, 2025 09:04
@provokateurin

Copy link
Copy Markdown
Member Author

Deck will also need a testing PR for this branch, as it relies on the same logic that is currently breaking Talk sharing tests (but I already have a solution): https://github.com/nextcloud/spreed/actions/runs/17404020365/job/49403633071?pr=15777

@provokateurin

Copy link
Copy Markdown
Member Author

nextcloud/deck#7219

@provokateurin

Copy link
Copy Markdown
Member Author

I ran all the failing Talk and Deck integration tests locally, but they all pass 🙈 I double checked that I'm really using the correct branches, but it was all as intended.

@provokateurin

Copy link
Copy Markdown
Member Author

I think this PR could be unblocked by #57295, as I was stuck on the VerifyMountPointEvent last time 🎉

@blizzz blizzz modified the milestones: Nextcloud 33, Nextcloud 34 Feb 16, 2026
@provokateurin provokateurin force-pushed the perf/base/basic-auth-fs-setup branch from 0786ca8 to df380d0 Compare February 24, 2026 09:17

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@provokateurin do we still need the cache mount then?

class CacheMountProvider implements IMountProvider {

@provokateurin

Copy link
Copy Markdown
Member Author

I'm not sure what you mean and how this is related 🤔

@susnux susnux removed this from the Nextcloud 34.0.1 milestone Jun 9, 2026
@CarlSchwan CarlSchwan force-pushed the perf/base/basic-auth-fs-setup branch from df380d0 to f73fb1f Compare June 10, 2026 15:09
Comment thread apps/files_sharing/tests/TestCase.php Outdated
@come-nc come-nc force-pushed the perf/base/basic-auth-fs-setup branch 2 times, most recently from 01ea5fa to ac5dc70 Compare June 18, 2026 09:27
Comment thread build/psalm-baseline.xml
@CarlSchwan CarlSchwan marked this pull request as ready for review June 23, 2026 12:35
@CarlSchwan CarlSchwan force-pushed the perf/base/basic-auth-fs-setup branch from ac5dc70 to c5a47a8 Compare June 23, 2026 12:35
provokateurin and others added 4 commits June 23, 2026 14:42
Signed-off-by: provokateurin <kate@provokateurin.de>
… local cache

Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan force-pushed the perf/base/basic-auth-fs-setup branch from c5a47a8 to 0c0bf73 Compare June 23, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Basic auth requests always set up the filesystem

8 participants