fix: podcast player panel draws under system navigation bar in main feed view#1669
Open
mvanhorn wants to merge 1 commit into
Open
fix: podcast player panel draws under system navigation bar in main feed view#1669mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
…eed view Fixes nextcloud#1647 Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The collapsed podcast playback panel no longer draws underneath the system navigation bar when playback starts from the main feed view. The bottom system-bar inset is now handled in the shared podcast panel code, so both host activities behave identically under edge-to-edge.
Why this matters
In #1647, @yukijoou narrowed the repro to playback started from the main feed without opening an article, which is why it did not reproduce at first:
activity_news_detail.xmlsetsfitsSystemWindowson its root CoordinatorLayout, butactivity_newsreader.xmlonly sets it on an inner CoordinatorLayout that does not contain thePodcastSlidingUpPanelLayout, leaving the panel flush with the physical screen bottom.Changes
OnApplyWindowInsetsListeneron the sliding panel raises the collapsed panel height by the system-bars bottom inset and pads the collapsed header so controls are not clipped.NewsDetailActivityalready consumes the inset viafitsSystemWindows, so the listener receives a zero bottom inset there and behavior is unchanged. The root ofactivity_newsreader.xmlintentionally keeps its existing edge-to-edge inset handling.Testing
Static review against both layout variants (portrait and sw600dp-land); the inset math only adds the reported bottom inset on top of the existing 68dp panel height. A device pass on API 35 edge-to-edge is the remaining verification, which CI/screenshots from the reporter's repro path will exercise.
Fixes #1647
Signed-off-by: Matt Van Horn 455140+mvanhorn@users.noreply.github.com