Add accessible header for the actions column#4812
Open
mvanhorn wants to merge 1 commit into
Open
Conversation
The actions column header in the Team folders settings table rendered an empty <th/>, so screen readers announced an unlabeled column for the per-row edit and delete controls. Add a visually hidden, translatable "Actions" label so assistive technologies announce the column while the visual layout stays unchanged. Fixes nextcloud#4464 Signed-off-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The actions column in the Team folders admin settings table rendered an empty
<th/>header cell. This adds a visually hidden, translatable "Actions" label so the column has an accessible name without changing the visual layout.Why this matters
The header cell for the per-row edit and delete controls had no text or accessible name, so screen readers announced an unlabeled column and assistive-technology users were left without context for the action controls in each row (#4464). The label uses the existing
hidden-visuallyclass (already used inSharingSidebarView.vue) and thet('groupfolders', ...)helper, so it is localized and visually hidden rather than shown as visible text. The column layout is unchanged.Testing
hidden-visually.eslint src/settings/App.tsxintroduces no new errors from this change (the pre-existing errors in the file are unrelated and present onmaster).Fixes #4464