perf(acl): cut per-folder/path DB queries during PROPFIND#4807
Open
solracsf wants to merge 1 commit into
Open
Conversation
solracsf
added
3. to review
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
solracsf
force-pushed
the
perf/propfind-acl-fix
branch
from
10efd5c to
d53a36b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PROPFIND on instances with many group folders is DB-heavy: ACL permission calculation re-queried static folder configuration on every path, and the ACL storage wrapper resolved each folder's numeric storage id separately, so
the query count scaled with the number of folders.
Fixes #4095.
Superseed #4676.
Benchmarks
Nextcloud 35 + MariaDB 11.4, 3600 group folders / 172k files. Query counts are deterministic.
getMountsForUserruns on every PROPFIND at the home rootFolderManagerTestcovers the memoization, cache invalidation (including on group and user deletion), and the storage-id invariant.🤖 AI (if applicable)