Skip to content

fix: Replace icon attributes with template slots #8093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luka-nextcloud merged 1 commit into from
Jun 22, 2026
Merged

fix: Replace icon attributes with template slots #8093

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions src/components/cards/CardMenuEntries.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,28 +24,36 @@
{{ t('deck', 'Edit title') }}
</NcActionButton>
<NcActionButton v-if="canEdit && !isCurrentUserAssigned"
icon="icon-user"
:close-after-click="true"
@click="assignCardToMe()">
<template #icon>
<AccountPlusIcon :size="20" decorative />
</template>
{{ t('deck', 'Assign to me') }}
</NcActionButton>
<NcActionButton v-if="canEdit && isCurrentUserAssigned"
icon="icon-user"
:close-after-click="true"
@click="unassignCardFromMe()">
<template #icon>
<AccountMinusIcon :size="20" decorative />
</template>
{{ t('deck', 'Unassign myself') }}
</NcActionButton>
<NcActionButton v-if="canEdit"
icon="icon-checkmark"
:close-after-click="true"
:disabled="isInDoneColumn && !!card.done"
@click="changeCardDoneStatus()">
<template #icon>
<CheckIcon :size="20" decorative />
</template>
{{ card.done ? t('deck', 'Mark as not done') : t('deck', 'Mark as done') }}
</NcActionButton>
<NcActionButton v-if="canEdit"
icon="icon-external"
:close-after-click="true"
@click="openCardMoveDialog">
<template #icon>
<OpenInNewIcon :size="20" decorative />
</template>
{{ t('deck', 'Move/copy card') }}
</NcActionButton>
<NcActionButton v-for="action in cardActions"
Expand All @@ -62,9 +70,11 @@
{{ card.archived ? t('deck', 'Unarchive card') : t('deck', 'Archive card') }}
</NcActionButton>
<NcActionButton v-if="canEdit"
icon="icon-delete"
:close-after-click="true"
@click="deleteCard()">
<template #icon>
<DeleteIcon :size="20" decorative />
</template>
{{ t('deck', 'Delete card') }}
</NcActionButton>
</div>
Expand All @@ -76,6 +86,11 @@ import ArchiveIcon from 'vue-material-design-icons/ArchiveOutline.vue'
import CardBulletedIcon from 'vue-material-design-icons/CardBulletedOutline.vue'
import PencilIcon from 'vue-material-design-icons/PencilOutline.vue'
import SelectColor from 'vue-material-design-icons/Circle.vue'
import AccountPlusIcon from 'vue-material-design-icons/AccountPlusOutline.vue'
import AccountMinusIcon from 'vue-material-design-icons/AccountMinusOutline.vue'
import CheckIcon from 'vue-material-design-icons/Check.vue'
import OpenInNewIcon from 'vue-material-design-icons/OpenInNew.vue'
import DeleteIcon from 'vue-material-design-icons/Delete.vue'
import { generateUrl } from '@nextcloud/router'
import { getCurrentUser } from '@nextcloud/auth'
import { showUndo } from '@nextcloud/dialogs'
Expand All @@ -86,7 +101,7 @@ import { useActionsStore } from '../../stores/actions.js'
export default {
name: 'CardMenuEntries',
components: { NcColorPicker, NcActionButton, ArchiveIcon, CardBulletedIcon, PencilIcon, SelectColor },
components: { NcColorPicker, NcActionButton, ArchiveIcon, CardBulletedIcon, PencilIcon, SelectColor, AccountPlusIcon, AccountMinusIcon, CheckIcon, OpenInNewIcon, DeleteIcon },
props: {
card: {
type: Object,
Expand Down
73 changes: 55 additions & 18 deletions src/components/navigation/AppNavigationBoard.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,19 @@

<template v-if="!deleted" slot="actions">
<template v-if="!isDueSubmenuActive">
<NcActionButton icon="icon-info"
:close-after-click="true"
<NcActionButton :close-after-click="true"
@click="actionDetails">
<template #icon>
<InformationOutlineIcon :size="20" decorative />
</template>
{{ t('deck', 'Board details') }}
</NcActionButton>
<NcActionButton v-if="canManage && !board.archived"
icon="icon-rename"
:close-after-click="true"
@click="actionEdit">
<template #icon>
<PencilIcon :size="20" decorative />
</template>
{{ t('deck', 'Edit board') }}
</NcActionButton>
<NcActionButton v-if="canCreate && !board.archived"
Expand Down Expand Up @@ -64,12 +68,18 @@
{{ t('deck', 'Archive board') }}
</NcActionButton>
<NcActionButton v-if="canManage && !board.archived"
icon="icon-download"
:close-after-click="true"
@click="actionExport">
<template #icon>
<DownloadIcon :size="20" decorative />
</template>
{{ t('deck', 'Export board') }}
</NcActionButton>
<NcActionButton v-if="!board.archived && board.acl?.length === 0" :icon="board.settings['notify-due'] === 'off' ? 'icon-sound' : 'icon-sound-off'" @click="board.settings['notify-due'] === 'off' ? updateSetting('notify-due', 'all') : updateSetting('notify-due', 'off')">
<NcActionButton v-if="!board.archived && board.acl?.length === 0" @click="board.settings['notify-due'] === 'off' ? updateSetting('notify-due', 'all') : updateSetting('notify-due', 'off')">
<template #icon>
<BellOutlineIcon v-if="board.settings['notify-due'] === 'off'" :size="20" decorative />
<BellOffOutlineIcon v-else :size="20" decorative />
</template>
{{ board.settings['notify-due'] === 'off' ? t('deck', 'Turn on due date reminders') : t('deck', 'Turn off due date reminders') }}
</NcActionButton>
<NcActionButton :close-after-click="true" @click="toggleDefaultBoard">
Expand All @@ -83,50 +93,62 @@

<!-- Due date reminder settings -->
<template v-if="isDueSubmenuActive">
<NcActionButton :icon="updateDueSetting ? 'icon-loading-small' : 'icon-view-previous'"
:disabled="updateDueSetting"
<NcActionButton :disabled="updateDueSetting"
@click="isDueSubmenuActive=false">
<template #icon>
<NcLoadingIcon v-if="updateDueSetting" :size="20" />
<ChevronLeftIcon v-else :size="20" decorative />
</template>
{{ t('deck', 'Due date reminders') }}
</NcActionButton>

<NcActionButton name="notification"
icon="icon-sound"
:disabled="updateDueSetting"
:class="{ 'forced-active': board.settings['notify-due'] === 'all' }"
@click="updateSetting('notify-due', 'all')">
<template #icon>
<BellOutlineIcon :size="20" decorative />
</template>
{{ t('deck', 'All cards') }}
</NcActionButton>
<NcActionButton name="notification"
icon="icon-user"
:disabled="updateDueSetting"
:class="{ 'forced-active': board.settings['notify-due'] === 'assigned' }"
@click="updateSetting('notify-due', 'assigned')">
<template #icon>
<AccountIcon :size="20" decorative />
</template>
{{ t('deck', 'Assigned cards') }}
</NcActionButton>
<NcActionButton name="notification"
icon="icon-sound-off"
:disabled="updateDueSetting"
:class="{ 'forced-active': board.settings['notify-due'] === 'off' }"
@click="updateSetting('notify-due', 'off')">
<template #icon>
<BellOffOutlineIcon :size="20" decorative />
</template>
{{ t('deck', 'No notifications') }}
</NcActionButton>
</template>
<NcActionButton v-else-if="!board.archived && board.acl?.length > 0"
:name="t('deck', 'Due date reminders')"
:icon="dueDateReminderIcon"
@click="isDueSubmenuActive=true">
<template #icon>
<component :is="dueDateReminderIcon" :size="20" decorative />
</template>
{{ dueDateReminderText }}
</NcActionButton>

<NcActionButton v-if="canManage && !isDueSubmenuActive"
icon="icon-delete"
:close-after-click="true"
@click="actionDelete">
<template #icon>
<DeleteIcon :size="20" decorative />
</template>
{{ t('deck', 'Delete board') }}
</NcActionButton>

<NcActionButton v-if="canLeave && !isDueSubmenuActive"
icon="icon-delete"
:close-after-click="true"
@click="actionLeave">
<template #icon>
Expand Down Expand Up @@ -171,7 +193,7 @@
</template>

<script>
import { NcAppNavigationIconBullet, NcAppNavigationItem, NcColorPicker, NcButton, NcTextField, NcActionButton } from '@nextcloud/vue'
import { NcAppNavigationIconBullet, NcAppNavigationItem, NcColorPicker, NcButton, NcTextField, NcActionButton, NcLoadingIcon } from '@nextcloud/vue'
import ClickOutside from 'vue-click-outside'
import ArchiveIcon from 'vue-material-design-icons/ArchiveOutline.vue'
import CloneIcon from 'vue-material-design-icons/ContentDuplicate.vue'
Expand All @@ -181,6 +203,13 @@ import CloseIcon from 'vue-material-design-icons/Close.vue'
import CheckIcon from 'vue-material-design-icons/Check.vue'
import PinIcon from 'vue-material-design-icons/Pin.vue'
import PinOffIcon from 'vue-material-design-icons/PinOff.vue'
import InformationOutlineIcon from 'vue-material-design-icons/InformationOutline.vue'
import PencilIcon from 'vue-material-design-icons/PencilOutline.vue'
import DownloadIcon from 'vue-material-design-icons/Download.vue'
import DeleteIcon from 'vue-material-design-icons/Delete.vue'
import ChevronLeftIcon from 'vue-material-design-icons/ChevronLeft.vue'
import BellOutlineIcon from 'vue-material-design-icons/BellOutline.vue'
import BellOffOutlineIcon from 'vue-material-design-icons/BellOffOutline.vue'

import { loadState } from '@nextcloud/initial-state'
import { emit } from '@nextcloud/event-bus'
Expand All @@ -202,6 +231,7 @@ export default {
NcButton,
NcTextField,
NcActionButton,
NcLoadingIcon,
AccountIcon,
ArchiveIcon,
CloneIcon,
Expand All @@ -210,6 +240,13 @@ export default {
PinIcon,
PinOffIcon,
LeaveIcon,
InformationOutlineIcon,
PencilIcon,
DownloadIcon,
DeleteIcon,
ChevronLeftIcon,
BellOutlineIcon,
BellOffOutlineIcon,
BoardCloneModal,
BoardExportModal,
},
Expand Down Expand Up @@ -269,13 +306,13 @@ export default {
},
dueDateReminderIcon() {
if (this.board.settings['notify-due'] === 'all') {
return 'icon-sound'
return 'BellOutlineIcon'
} else if (this.board.settings['notify-due'] === 'assigned') {
return 'icon-user'
return 'AccountIcon'
} else if (this.board.settings['notify-due'] === 'off') {
return 'icon-sound-off'
return 'BellOffOutlineIcon'
}
return ''
return 'BellOutlineIcon'
},
dueDateReminderText() {
if (this.board.settings['notify-due'] === 'all') {
Expand Down
Loading