Skip to content

Vue3 remove compat #7003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grnd-alt wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Vue3 remove compat #7003

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
452dc5f
get deck to build with vue3 with broken functionality
grnd-alt Jan 27, 2025
c32115d
vue3-with non-local dependencies and part of the functionality
grnd-alt Jan 28, 2025
0f1d118
fix: correct syntax for scss variables
grnd-alt Mar 10, 2025
8e805db
fix: use vue3 slot syntax
grnd-alt Mar 10, 2025
b59b2ed
use v-model instead of value:sync
grnd-alt Mar 25, 2025
30e74a7
fix: rename parameter names deprecated in vue3
grnd-alt Apr 15, 2025
f4acf38
replace Vue.set with direct setting
grnd-alt May 12, 2025
1110a4f
use correct prop name for nextcloud/vue vue3
grnd-alt May 12, 2025
03d2bd9
fix: remove extra component for NcAction entries
grnd-alt May 12, 2025
ee10097
fix: adapt NcButtons to nextcloud-vue 9
grnd-alt Jun 24, 2025
1d7bf30
bump @nextcloud/dialogs to 7.0.0-rc.1
grnd-alt Jun 24, 2025
f3a8de2
fix: stabilize cypress
grnd-alt Jun 24, 2025
85af54c
fix: do not clean webpack-stats.json from build files
grnd-alt Jul 8, 2025
981d1cb
fix: remove deprecated ToolTip
grnd-alt Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cypress/e2e/cardFeatures.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ describe('Card', function () {
cy.get('.modal-mask.card-selector .multiselect-list').should('be.visible').click()
cy.get('.vs__dropdown-menu span[title="TestList"]').should('be.visible').click()

cy.get('.modal-mask.card-selector button.button-vue--vue-primary').should('be.visible').click()
cy.get('.modal-mask.card-selector button.button-vue--primary').contains('Create card').should('be.visible').click()
cy.wait('@save', { timeout: 7000 })

cy.reload()
Expand Down Expand Up @@ -187,7 +187,7 @@ describe('Card', function () {
cy.get('.file-picker__main').should('be.visible')
cy.get('.file-picker__main [data-filename="welcome.txt"]', { timeout: 30000 }).should('be.visible')
.click()
cy.get('.dialog__actions button.button-vue--vue-primary').click()
cy.get('.dialog__actions button.button-vue--primary').click()
cy.get('.attachment-list .filename').contains('welcome')
cy.get('.attachment-list .filename .extension').contains('txt')
})
Expand Down Expand Up @@ -302,8 +302,10 @@ describe('Card', function () {
.first().click()
cy.get(`.card:contains("${newCardTitle}")`).should('be.visible').click()

cy.get('#app-sidebar-vue [data-test="tag-selector"] .vs__dropdown-toggle').should('be.visible').click()
cy.get('#app-sidebar-vue [data-test="tag-selector"] .vs__dropdown-toggle .vs__actions').should('be.visible').click()
cy.get('.vs__dropdown-menu .tag:contains("Action needed")').should('be.visible').click()
cy.get('.vs__dropdown-menu .tag:contains("Later")').should('not.exist')
cy.get('#app-sidebar-vue [data-test="tag-selector"] .vs__dropdown-toggle .vs__actions').should('be.visible').click()
cy.get('.vs__dropdown-menu .tag:contains("Later")').should('be.visible').click()

cy.get('.vs__selected .tag:contains("Action needed")').should('be.visible')
Expand Down
2 changes: 1 addition & 1 deletion cypress/e2e/deckDashboard.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe('Deck dashboard', function() {

const defaultBoard = 'Welcome to Nextcloud Deck!'

cy.get('.app-navigation-entry-wrapper[icon=icon-deck]')
cy.get('#deck-navigation-all')
.find('ul.app-navigation-entry__children .app-navigation-entry:contains(' + defaultBoard + ')')
.first()
.contains(defaultBoard)
Expand Down
2 changes: 1 addition & 1 deletion cypress/support/commands.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ Cypress.Commands.add('createExampleBoard', ({ user, board }) => {
})

Cypress.Commands.add('getNavigationEntry', (boardTitle) => {
return cy.get('.app-navigation-entry-wrapper[icon=icon-deck]')
return cy.get('#deck-navigation-all')
.find('ul.app-navigation-entry__children .app-navigation-entry:contains(' + boardTitle + ')')
.find('a.app-navigation-entry-link')
})
Expand Down
Loading
Loading