Skip to content

chore: getBasedOn() is nullable #2519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SystemKeeper wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: getBasedOn() is nullable #2519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/IFederatedUser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,9 @@ public function getDisplayName(): string;
public function setBasedOn(?Circle $basedOn): self;

/**
* @return Circle
* @return ?Circle
*/
public function getBasedOn(): Circle;
public function getBasedOn(): ?Circle;

/**
* @return bool
Expand Down
6 changes: 3 additions & 3 deletions lib/Model/FederatedUser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class FederatedUser extends ManagedModel implements
/** @var string */
private $displayName = '';

/** @var Circle */
/** @var ?Circle */
private $basedOn;

/** @var int */
Expand Down Expand Up @@ -195,9 +195,9 @@ public function setBasedOn(?Circle $basedOn): self {
}

/**
* @return Circle
* @return ?Circle
*/
public function getBasedOn(): Circle {
public function getBasedOn(): ?Circle {
return $this->basedOn;
}

Expand Down
8 changes: 4 additions & 4 deletions lib/Model/Member.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ class Member extends ManagedModel implements
/** @var int */
private $userType = 0;

/** @var Circle */
/** @var ?Circle */
private $basedOn;

/** @var Member */
Expand Down Expand Up @@ -384,9 +384,9 @@ public function setBasedOn(?Circle $basedOn): self {
}

/**
* @return Circle
* @return ?Circle
*/
public function getBasedOn(): Circle {
public function getBasedOn(): ?Circle {
return $this->basedOn;
}

Expand Down Expand Up @@ -721,7 +721,7 @@ public function getLink(string $singleId, bool $detailed = false): Membership {
if ($singleId !== '') {
$this->getManager()->getLink($this, $singleId, $detailed);
}

throw new MembershipNotFoundException();
}

Expand Down
Loading