Skip to content

fix(appointments): fix mobile layout overflow hiding booking buttons #8622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
awikatchikaen wants to merge 1 commit into
base: stable6.5
Choose a base branch
from
+65 −4
Open

fix(appointments): fix mobile layout overflow hiding booking buttons #8622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions src/components/Appointments/AppointmentDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,12 @@ h3 {
max-width: 720px;
max-height: 500px;
overflow: auto;

@media (max-width: 768px) {
width: 100%;
max-height: none;
overflow: visible;
}
}

.booking-appointment-wrapper {
Expand All @@ -239,20 +245,32 @@ h3 {
flex-wrap: wrap;
gap: calc(var(--default-grid-baseline) * 6);
width: 100%;

@media (max-width: 768px) {
flex-direction: column;
gap: calc(var(--default-grid-baseline) * 4);
}
}

.booking-details {
flex: 1 220px;
min-width: 0;
}

.appointment-details {
max-width: 360px;
flex: 1 auto;
padding-inline-start: 30px;
min-width: 0;

input {
width: 100%;
}

@media (max-width: 768px) {
max-width: 100%;
padding-inline-start: 0;
}
}

.buttons .loading-icon {
Expand Down
51 changes: 47 additions & 4 deletions src/views/Appointments/Booking.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,20 +260,35 @@ export default {
#appointment-booking {
display: flex;
justify-content: center;
align-items: center;
// center would push .booking__container off-screen (negative offset) once it's taller than this box
align-items: flex-start;
width: 100%;
height: 100%;
min-height: 100%;
}

@media (max-width: 768px) {
// Hidden instead of reserved-for: overlaps booking content otherwise
footer {
display: none;
}
}
</style>

<style lang="scss" scoped>
.booking__container {
display: flex;
width: 100%;
height: 100vh;
min-height: calc(100vh - var(--header-height, 50px) - var(--footer-height, 65px));
min-height: calc(100dvh - var(--header-height, 50px) - var(--footer-height, 65px));
flex-direction: column;
justify-content: center;
align-items: center;

@media (max-width: 768px) {
// Footer is hidden on mobile (see unscoped style block), so no need to reserve space for it
min-height: calc(100vh - var(--header-height, 50px));
min-height: calc(100dvh - var(--header-height, 50px));
}
}

.booking {
Expand All @@ -285,17 +300,41 @@ export default {
padding-top: calc(var(--default-grid-baseline) * 4);
padding-bottom: calc(var(--default-grid-baseline) * 4);
padding-inline: calc(var(--default-grid-baseline) * 4);
margin-bottom: var(--footer-height);

@media (max-width: 768px) {
flex-direction: column;
padding-inline: calc(var(--default-grid-baseline) * 2);
}
}

.booking__description {
white-space: break-spaces;
}

.booking__config-user-info,
.booking__date-selection,
.booking__slot-selection {
min-width: 0;
}

.booking__date-selection {
display: flex;
flex-direction: column;
gap: calc(var(--default-grid-baseline) * 2);

@media (max-width: 768px) {
overflow-x: auto;
}
}

.booking__time-zone {
@media (max-width: 768px) {
width: 100%;

:deep(.v-select) {
width: 100%;
}
}
}

.booking__slots {
Expand All @@ -307,6 +346,10 @@ export default {

.booking__slot-selection {
min-width: 180px;

@media (max-width: 768px) {
min-width: 0;
}
}

:deep(.mx-input-wrapper) {
Expand Down