refactor: remove usage of this._uid in Vue components#8593
Merged
Conversation
odzhychko
requested review from
GVodyanov,
SebastianKrupinski and
tcitworld
as code owners
July 13, 2026 11:33
odzhychko
force-pushed
the
refactor-uid
branch
2 times, most recently
from
July 13, 2026 11:35
5246cb2 to
394eb26
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
Hey, "this._uid" is dead vue 2 code, and should be removed |
Resolves the browser warning `[Vue warn]: Property "_uid" was accessed during render but is not defined on instance.` None of the changed code caused a known user-facing issue. `this._uid` was an internal API and is `undefined` since Vue 3. The recommended way to get unique IDs is `useId()`. Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
Contributor
Author
I removed the non-required usages of |
SebastianKrupinski
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves the browser warning
[Vue warn]: Property "_uid" was accessed during render but is not defined on instance.None of the changed code caused a known user-facing issue.this._uidwas an internal API and isundefinedsince Vue 3. The recommended way to get unique IDs isuseId().In some places, I encountered usage of
this._uidin some suspicious code that might hint at something forgotten during previous refactoring and maybe a bug. I don't want to look into the details there for now, so I leftXXXcomments.