fix: edit simple buttons running away#8533
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
GVodyanov
force-pushed
the
fix/edit-simple-buttons
branch
from
b74033e to
06ef8cf
Compare
SebastianKrupinski
left a comment
SebastianKrupinski
left a comment
Contributor
There was a problem hiding this comment.
Tested works.
In general binding the pop over to the body instead of the anchor seems to fix unknown size issue when calculating the height, very well.
Don't remember the reasoning for not doing this in the first place, at the moment
Signed-off-by: Grigory V <scratchx@gmx.com>
GVodyanov
force-pushed
the
fix/edit-simple-buttons
branch
from
06ef8cf to
ac9a676
Compare
SebastianKrupinski
approved these changes
Jun 25, 2026
SebastianKrupinski
left a comment
SebastianKrupinski
left a comment
Contributor
There was a problem hiding this comment.
Tested. Changes work great
Contributor
|
/backport to stable6.5 |
backportbot
Bot
added
the
backport-request
backportbot
Bot
removed
the
backport-request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #8523
Fixes:
Makes it so that the buttons are anchored to the bottom of the component so they are always accessible. If there is not enough space to display everything in the component you scroll down to the attendees.
🤖 AI (if applicable)