Skip to content

fix: reinitialize inputs on New Task button click#395

Merged
janepie merged 2 commits into
nextcloud:mainfrom
rroma:fix/383/contextchat-new-task-submit-disabled
Nov 25, 2025
Merged

fix: reinitialize inputs on New Task button click#395
janepie merged 2 commits into
nextcloud:mainfrom
rroma:fix/383/contextchat-new-task-submit-disabled

Conversation

@rroma

@rroma rroma commented Nov 11, 2025

Copy link
Copy Markdown
Contributor
  • This fix adds reinitialization of context chat input form on the New Task button click

Fixes #383

Signed-off-by: Roman Romanov <rroma.dev@gmail.com>
@rroma rroma force-pushed the fix/383/contextchat-new-task-submit-disabled branch from 0820087 to e7a0421 Compare November 11, 2025 21:42
@julien-nc julien-nc self-requested a review November 12, 2025 09:42
@julien-nc

Copy link
Copy Markdown
Member

Nice, it fixes the issue.
Any reason you defined the handler? Since you are not adding a "deep" watcher you can make the watcher just like the other ones, like the taskType(newValue) { one for example.

Signed-off-by: Roman Romanov <rroma.dev@gmail.com>
@rroma

rroma commented Nov 12, 2025

Copy link
Copy Markdown
Contributor Author

Makes sense, thank you. I’ve just removed the handler.

@janepie janepie requested review from janepie and removed request for julien-nc November 25, 2025 14:13
@janepie janepie merged commit 743f2f8 into nextcloud:main Nov 25, 2025
9 checks passed
@janepie janepie mentioned this pull request Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clicking on "New Task" in ContextChat view permanently disables submit button

3 participants