Skip to content

fix(backup-fragment): lifecycle, permission management#17027

Open
alperozturk96 wants to merge 3 commits into
masterfrom
fix/backup
Open

fix(backup-fragment): lifecycle, permission management#17027
alperozturk96 wants to merge 3 commits into
masterfrom
fix/backup

Conversation

@alperozturk96
Copy link
Copy Markdown
Collaborator

Issue

Previously selected switch was not active after re-open the BackupFragment

Changes

  • Replaces deprecated API usages (ActivityResultContracts instead onRequestPermissionsResult and MenuProvider instead onOptionsItemSelected)
  • Better permission change listeners
  • Fixes fragment lifecycle issues
  • Simplified logic

Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
Copy link
Copy Markdown
Collaborator Author

/backport to stable-33.1.x

@github-actions
Copy link
Copy Markdown

blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed.

@github-actions
Copy link
Copy Markdown

Codacy

SpotBugs

CategoryBaseNew
Bad practice3535
Correctness6767
Dodgy code216216
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3434
Performance4242
Security1616
Total420420

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link
Copy Markdown

APK file: https://github.com/nextcloud/android/actions/runs/25670973676/artifacts/6919544855
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants