[TP-TS] To Do 미션 Step5 - 신다혜#87
Open
dahye1013 wants to merge 8 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
제 접근 방식과 설계 자체에 문제가 있는 것 같아서 계속 고민하면서 못하고 있다가
일단 되는데까지 하면서 하나라도 더 배워야겠다고 생각했습니다^^...
등록, 기본 수정 밖에 구현을 못해서 추가 구현하면서 타입에러랑 코드 정리도 해보도록 하겠습니다
인스턴스화가 아니라 설계할때부터 인터페이스 기조로 했어야 했구나.... 라는 깨달음을 하나 얻었습니다..
처음에 모든 객체의 id를 number 타입으로 설계했었는데,
dataSet에서 꺼내온 string 타입의 id로 정보를 수정하려고하니 타입에러가 나서 디버깅하기 좋았던 것 같습니다.