Fix duplicate variables in models#149
Open
JCGoran wants to merge 2 commits into
Open
Conversation
Collaborator
Author
|
This actually passes the CI when launched with the right inputs: https://github.com/neuronsimulator/nrn-modeldb-ci/actions/runs/18007353985/job/51230698924 The reason why it's failing for the PR CI is again due to not backporting neuronsimulator/nrn#3093, the above was run with the wheel from neuronsimulator/nrn#3163. |
JCGoran
marked this pull request as ready for review
September 25, 2025 12:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148.
MODELS_TO_RUN=48332 84589 97860 98005 105385 122329 123453 125689 150551 180789 244922 258643 266578 267140 267599 2018017