ci: adopt canonical skill template#87
Merged
Merged
Conversation
Drift-enforced canonical CI with explicit per-call-site permissions. CodeQL via default setup. Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
Contributor
Dependency ReviewThe following issues were found:
License Issues.github/workflows/scorecard.yml
.github/workflows/security.yml
OpenSSF Scorecard
Scanned Files
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
=========================================
Coverage 66.71% 66.71%
Complexity 807 807
=========================================
Files 45 45
Lines 2289 2289
=========================================
Hits 1527 1527
Misses 762 762
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ositive unlink SAST This repo is a PHP composer plugin, not a skill repo. Re-scope the .github/ governance from the skill template to the php-module template: - Remove skill-only workflows (eval-validate, harness-verify, lint). - Sync security.yml, scorecard.yml, check-template-drift.yml and template.yaml byte-identically from netresearch/.github templates/php-module/. dependabot.yml, labeler.yml and auto-merge-deps.yml were already byte-identical. - Keep the repo's own ci.yml and release.yml (PHP test/lint/release). Add scoped Opengrep suppressions for 6 confirmed false-positive php.lang.security.unlink-use findings. Five are the safe atomic-write cleanup pattern (unlink of a freshly-created random-named temp file on rename failure); one is recursive cleanup of plugin-managed directory contents from directory iteration. None use untrusted input. Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if (!rename($tempPath, $agentsMdPath)) { | ||
| @unlink($tempPath); | ||
| // cleanup of our own freshly-created temp file (random name) on atomic-write rename failure; path is not user input | ||
| @unlink($tempPath); // nosemgrep: php.lang.security.unlink-use.unlink-use |
| if (!rename($temp, $path)) { | ||
| @unlink($temp); | ||
| // cleanup of our own freshly-created temp file (random name) on atomic-write rename failure; path is not user input | ||
| @unlink($temp); // nosemgrep: php.lang.security.unlink-use.unlink-use |
| if (!@rename($tempPath, $this->composerJsonPath)) { | ||
| @unlink($tempPath); | ||
| // cleanup of our own freshly-created temp file (random name) on atomic-write rename failure; path is not user input | ||
| @unlink($tempPath); // nosemgrep: php.lang.security.unlink-use.unlink-use |
| if (!rename($temp, $composerJsonPath)) { | ||
| @unlink($temp); | ||
| // cleanup of our own freshly-created temp file (random name) on atomic-write rename failure; path is not user input | ||
| @unlink($temp); // nosemgrep: php.lang.security.unlink-use.unlink-use |
| if (!rename($temp, $composerJsonPath)) { | ||
| @unlink($temp); | ||
| // cleanup of our own freshly-created temp file (random name) on atomic-write rename failure; path is not user input | ||
| @unlink($temp); // nosemgrep: php.lang.security.unlink-use.unlink-use |
| } | ||
| } elseif (file_exists($path) && !unlink($path)) { | ||
| // recursive cleanup of plugin-managed directory contents; path from directory iteration, not user input | ||
| } elseif (file_exists($path) && !unlink($path)) { // nosemgrep: php.lang.security.unlink-use.unlink-use |
Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate CI to the canonical
skilltemplate (netresearch/.github): explicit per-call-site permissions on every reusable, drift-enforced. CodeQL via default setup.