FEAT: Move storefront to requrei to pass shopware static code analysis#56
Merged
Merged
Conversation
Shopware runs phpstan without dev and therefore the UrlEncodingTwigFilter class not exists. This class is needed here src/Decorator/UrlEncodingTwigFilterDecorator.php.
Error from the phpstan:
Warnings of the static code analysis:
---------------------------------------------------------------------------
Error
-- ---------------------------------------------------------------------------
Internal error: Class
Shopware\Storefront\Framework\Twig\Extension\UrlEncodingTwigFilter was
not found while trying to analyse it - discovering symbols is probably
not configured properly. while analysing file
/tmp/plugincheck/NlxSwImgproxy/src/Decorator/UrlEncodingTwigFilterDecorat
or.php
Run PHPStan with -v option and post the stack trace to:
https://github.com/phpstan/phpstan/issues/new?template=Bug_report.yaml
-- ---------------------------------------------------------------------------
[ERROR] Found 1 error
⚠️ Result is incomplete because of severe errors. ⚠️
Fix these errors first and then re-run PHPStan
to get all reported errors.
Jnoack331
approved these changes
Jun 25, 2026
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shopware runs phpstan without dev and therefore the UrlEncodingTwigFilter class not exists. This class is needed here src/Decorator/UrlEncodingTwigFilterDecorator.php.
Error from the phpstan:
Warnings of the static code analysis:
[ERROR] Found 1 error
Fix these errors first and then re-run PHPStan
to get all reported errors.