New feature cert verify#978
Merged
Merged
Conversation
LanutiEmanuele
requested review from
AndryNick98,
LucaNicosia,
Sepehr-A,
claudious96 and
ddutt
LucaNicosia
requested changes
Feb 21, 2025
LucaNicosia
left a comment
LucaNicosia
left a comment
Collaborator
There was a problem hiding this comment.
Please add some validation during the load of the context to verify that only a path or bool is passed. Moreover check if the path is valid
Also, add this parameter to the docs
LanutiEmanuele
force-pushed
the
feature/cert-verify
branch
2 times, most recently
from
245a8dd to
badfcf2
Compare
LucaNicosia
approved these changes
Feb 26, 2025
rickstardust
approved these changes
May 6, 2025
rickstardust
left a comment
rickstardust
left a comment
Contributor
There was a problem hiding this comment.
Please fix the indentation
ddutt
approved these changes
May 6, 2025
LanutiEmanuele
force-pushed
the
feature/cert-verify
branch
from
badfcf2 to
89c5553
Compare
Signed-off-by: Emanuele Lanuti <emanuele.lanuti@stardustsystems.net>
Signed-off-by: Emanuele Lanuti <emanuele.lanuti@stardustsystems.net>
Signed-off-by: Lanuti_emanuele <emanuele.lanuti@stardustsystems.net> Signed-off-by: Emanuele Lanuti <emanuele.lanuti@stardustsystems.net>
Signed-off-by: Lanuti_emanuele <emanuele.lanuti@stardustsystems.net> Signed-off-by: Emanuele Lanuti <emanuele.lanuti@stardustsystems.net>
Signed-off-by: Emanuele Lanuti <emanuele.lanuti@stardustsystems.net>
Signed-off-by: Emanuele Lanuti <emanuele.lanuti@stardustsystems.net>
LanutiEmanuele
force-pushed
the
feature/cert-verify
branch
from
4e1416f to
6f125c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New feature to set cert verify
Description
Now the user can set how to use the certificate
cert-verify can be set to False, True, CA_path
With False the certificate will not be verified
With True the certificate will be verified
With the CA_path the certificate will be verified according to the indicated CA
Changes
I added the 'cert-verify' parameter in suzie q-cfg.
The parameter is read and used by engineobj.
I added a CA for testing purposes.
Type of change
Double Check
developbranch.developbranch.--signoffapplied