Fix the missing rest engine context#976
Merged
Merged
Conversation
LanutiEmanuele
requested review from
AndryNick98,
LucaNicosia,
Sepehr-A,
claudious96 and
ddutt
LucaNicosia
reviewed
Feb 21, 2025
LanutiEmanuele
force-pushed
the
fix/rest-engine-context
branch
from
4d871ae to
251f0bc
Compare
LucaNicosia
approved these changes
Feb 26, 2025
rickstardust
approved these changes
May 6, 2025
rickstardust
left a comment
rickstardust
left a comment
Contributor
There was a problem hiding this comment.
One new mypy failure to fix
LanutiEmanuele
force-pushed
the
fix/rest-engine-context
branch
2 times, most recently
from
a8ce6c4 to
3ccc995
Compare
Sepehr-A
approved these changes
May 7, 2025
Sepehr-A
left a comment
Sepehr-A
left a comment
Collaborator
There was a problem hiding this comment.
Approving with a comment.
ddutt
approved these changes
May 7, 2025
ddutt
left a comment
ddutt
left a comment
Member
There was a problem hiding this comment.
Approved with "please fix Sepehr's comment"
Signed-off-by: Lanuti_emanuele <emanuele.lanuti@stardustsystems.net>
Signed-off-by: Lanuti_emanuele <emanuele.lanuti@stardustsystems.net>
Signed-off-by: Lanuti_emanuele <emanuele.lanuti@stardustsystems.net>
Signed-off-by: Lanuti_emanuele <emanuele.lanuti@stardustsystems.net>
Signed-off-by: Emanuele Lanuti <emanuele.lanuti@stardustsystems.net>
Signed-off-by: Emanuele Lanuti <emanuele.lanuti@stardustsystems.net>
LanutiEmanuele
force-pushed
the
fix/rest-engine-context
branch
from
3ccc995 to
bf843ca
Compare
Sepehr-A
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed how set engine='rest' updates rest parameters
Description
When the cli was started with pandas and engine='rest' was set, the loaded data remained the default.
I created a 'set_rest_engine' function in shared/utils to extrapolate the correct data to update the parameters of the rest engine.
I updated the rest params in context_commands.set_ctxt.
I updated SQContext's post_init method
Type of change
Bug fix (non-breaking change which fixes an issue)
I have read the comments and followed the CONTRIBUTING.md.
I have explained my PR according to the information in the comments or in a linked issue.
My PR source branch is created from the
developbranch.My PR targets the
developbranch.All my commits have
--signoffapplied