Document combined-server disableLegacyPort setting - #1016
josipstojanovic-boop wants to merge 1 commit into
Conversation
|
@josipstojanovic-boop is attempting to deploy a commit to the NetBird GmbH Team on Vercel. A member of the Team first needs to authorize it. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe ChangesServer configuration reference
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to The reference’s listener behavior is consistent with available server evidence. Confirm the corresponding server change is present before operators rely on the new setting. Security Architecture ReviewSecurity architecture risk: 🔵 Low · up to The documentation clearly distinguishes the compatibility listener from the configured server listener and warns against disabling it while clients still depend on it. No introduced security weakness is established. However, support for the exact setting in the companion server release and the required release ordering remain unverified. Retained concerns Security review detailsSecurity Blast Radius
Trust Boundaries and Controls
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
src/pages/selfhosted/maintenance/configuration-files.mdxtypescript-eslint does not support TS 7.0. Oops! Something went wrong! :( ESLint: 9.39.5 Error: typescript-eslint does not support TS 7.0. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit reads the server page Comment |
Document
server.disableLegacyPortfor the combined server introduced by netbirdio/netbird#6913. Explain the default compatibility behavior, the prerequisite that clients no longer need the legacy listener, and that the explicitly configured server listener remains active.This documentation should merge with or after the server change.
Validation:
npm run lint:mdxandnpm run buildpassed locally.Summary by CodeRabbit
server.disableLegacyPortsetting, which disables the legacy management listener on port 33073. It defaults tofalse; the configured listen address remains active.