feat(graphql): support explicit args type names#4024
Open
xudongcc wants to merge 1 commit into
Open
Conversation
1 task
Member
|
could you target this #3973 branch? |
3378cd3 to
f8da599
Compare
Author
@kamilmysliwiec Thanks! I've retargeted this PR to the v14.0.0 branch and rebased it. The conflict is resolved and CI is green now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
@ObjectType()and@InputType()support explicit GraphQL type names through@ObjectType(name, options?)and@InputType(name, options?), but@ArgsType()only acceptsArgsTypeOptionsand always uses the TypeScript class name for metadata.Issue Number: #4023
What is the new behavior?
@ArgsType()now supports the same explicit-name overload shape:The implementation follows the existing
ObjectTypeandInputTypedecorator pattern, preservingArgsTypeOptionssuch asregisterInand falling back totarget.namewhen no explicit name is provided. The browser/react-native model shim accepts the same arguments.Does this PR introduce a breaking change?
Other information
Verified with: