Repository navigation
Move the complexity gate from ESLint to Biome - #185
Merged
Merged
Conversation
This repo used ESLint for one rule, sonarjs/cognitive-complexity, with @typescript-eslint/parser only to parse TypeScript, and that parser refuses TypeScript 7, so a lint dependency gated the compiler. Biome enforces the same ceiling of 15 with noExcessiveCognitiveComplexity (biome.json), has no TypeScript dependency, and drops the ESLint toolchain, as @nest-native/jobs did. The report reads Biome's JSON and refuses an empty scope or a truncated run; CI's base-branch report degrades to no baseline when the tooling changed since the base commit.
📊
|
| Metric | PR | Base | Diff | |
|---|---|---|---|---|
| Statements | ████████████████████ |
660/660 (100%) |
660/660 (100%) |
⚪ 0% |
| Branches | ████████████████████ |
280/280 (100%) |
280/280 (100%) |
⚪ 0% |
| Functions | ████████████████████ |
122/122 (100%) |
122/122 (100%) |
⚪ 0% |
| Lines | ████████████████████ |
635/635 (100%) |
635/635 (100%) |
⚪ 0% |
Updated for 78d4a4e | Compared against base branch
⏱️ Performance Report
🐢 Slowest test suites
🐌 Slowest individual tests
Updated for |
🧠 Cognitive Complexity Report
🧩 Most complex functions
Updated for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This repo used ESLint for one rule, sonarjs/cognitive-complexity, with
@typescript-eslint/parser only to parse TypeScript, and that parser
refuses TypeScript 7, so a lint dependency gated the compiler. Biome
enforces the same ceiling of 15 with noExcessiveCognitiveComplexity
(biome.json), has no TypeScript dependency, and drops the ESLint
toolchain, as @nest-native/jobs did. The report reads Biome's JSON and
refuses an empty scope or a truncated run; CI's base-branch report
degrades to no baseline when the tooling changed since the base commit.
Scope Check
packages/trpc/**changes.
Validation
# npm run complexity:check and complexity:report pass under BiomeSecurity Pass