Skip to content

Fixing actions, removing deprecated stuff, etc #36

Merged
lucasparreira merged 6 commits into
masterfrom
enginfs-545300/move-actions
Oct 1, 2025
Merged

Fixing actions, removing deprecated stuff, etc #36
lucasparreira merged 6 commits into
masterfrom
enginfs-545300/move-actions

Conversation

@lucasparreira
Copy link
Copy Markdown
Contributor

@lucasparreira lucasparreira commented Oct 1, 2025

This is mostly fixing broken actions and improving security.

Details

  • Getting rid of "set-output" as it's deprecated.
  • Moving build/commit workflow to "publish" action, which is also now scoped to "production".
  • Updating neofinancial/coverage-upload-action to latest to fix coverage job issue.
  • As we're no longer building/committing in the pull request action, added a note in the readme file on how to test feature branches.
  • Changing all runners to Ubuntu 22.04.
  • Limiting access for GITHUB_TOKEN.

Additional context

N/A

- Moving build/commit workflow to publish action, which is also now scoped to production.
- Updating neofinancial/coverage-upload-action to latest to fix coverage job issue.
- As we're no longer building/committing in the pull request action, added a note in the readme file on how to test feature branches.
- Changing all runners to Ubuntu 22.04.
Comment thread .github/workflows/publish.yaml Fixed
neobot1 and others added 3 commits October 1, 2025 19:31
@lucasparreira lucasparreira requested a review from Copilot October 1, 2025 19:35
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes GitHub Actions workflows by removing deprecated features and improving security practices. The changes move build/commit operations from pull request workflow to the publish workflow, update deprecated GitHub Actions syntax, and implement better access controls.

  • Replaces deprecated set-output commands with the new $GITHUB_OUTPUT syntax
  • Moves build and commit operations from pull request workflow to production-scoped publish workflow
  • Updates runner versions and implements stricter token permissions

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
README.md Adds documentation for testing feature branches before release
.github/workflows/pull-request.yaml Removes build/commit steps and updates deprecated syntax
.github/workflows/publish.yaml Consolidates build/commit operations with production environment scoping
.github/workflows/ci.yaml Updates deprecated set-output syntax

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/publish.yaml
Comment thread .github/workflows/publish.yaml
@lucasparreira lucasparreira merged commit 106d20a into master Oct 1, 2025
5 checks passed
@lucasparreira lucasparreira deleted the enginfs-545300/move-actions branch October 1, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants