Fixing actions, removing deprecated stuff, etc #36
Merged
Conversation
- Moving build/commit workflow to publish action, which is also now scoped to production. - Updating neofinancial/coverage-upload-action to latest to fix coverage job issue. - As we're no longer building/committing in the pull request action, added a note in the readme file on how to test feature branches. - Changing all runners to Ubuntu 22.04.
Signed-off-by: NeoBot <neomcneoface@neofinancial.com>
…o enginfs-545300/move-actions
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes GitHub Actions workflows by removing deprecated features and improving security practices. The changes move build/commit operations from pull request workflow to the publish workflow, update deprecated GitHub Actions syntax, and implement better access controls.
- Replaces deprecated
set-outputcommands with the new$GITHUB_OUTPUTsyntax - Moves build and commit operations from pull request workflow to production-scoped publish workflow
- Updates runner versions and implements stricter token permissions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Adds documentation for testing feature branches before release |
| .github/workflows/pull-request.yaml | Removes build/commit steps and updates deprecated syntax |
| .github/workflows/publish.yaml | Consolidates build/commit operations with production environment scoping |
| .github/workflows/ci.yaml | Updates deprecated set-output syntax |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eduardoyuidy
approved these changes
Oct 1, 2025
beraki
approved these changes
Oct 1, 2025
tjamescouch
approved these changes
Oct 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is mostly fixing broken actions and improving security.
Details
Additional context
N/A