Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ class UnusedDependencyRule extends ModelAwareGradleLintRule {

@Override
void visitGradleDependency(MethodCallExpression call, String declaredConf, GradleDependency dep) {
if (ignored) {
return // short-circuit ignored dependencies
}
String conf = dependencyService.findAndReplaceNonResolvableConfiguration(project.configurations.getByName(declaredConf)).name

if(SourceSetUtils.hasSourceSets(project)) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,65 @@ class UnusedDependencyRuleSpec extends BaseIntegrationTestKitSpec {
assert result.output.contains(it)
}
}

@Issue('#380')
def 'ignore dependencies in closures when rule is ignored'() {
setup:
buildFile.text = """
plugins {
id 'java'
id 'nebula.lint'
}

gradleLint.rules = ['all-dependency']

repositories { mavenCentral() }

dependencies {
implementation 'com.google.guava:guava:18.0'
gradleLint.ignore('unused-dependency') {
implementation 'org.apache.httpcomponents:httpclient:4.5.3'
}
}
"""

when:
writeJavaSourceFile(main)
def result = runTasks('compileJava')

then:
!result.output.contains('warning unused-dependency this dependency is unused and can be removed')
}

@Issue('#380')
def 'dont ignore dependencies not in closures when rule is ignored'() {
setup:
buildFile.text = """
plugins {
id 'java'
id 'nebula.lint'
}

gradleLint.rules = ['all-dependency']

repositories { mavenCentral() }

dependencies {
implementation 'com.google.guava:guava:18.0'
implementation 'org.apache.poi:poi:5.2.5'
gradleLint.ignore('unused-dependency') {
implementation 'org.apache.httpcomponents:httpclient:4.5.3'
}
}
"""

when:
writeJavaSourceFile(main)
def result = runTasks('compileJava')

then:
result.output.contains('warning unused-dependency this dependency is unused and can be removed')
}

def dependencies(File _buildFile, String... confs = ['compile', 'testCompile', 'implementation', 'testImplementation', 'api']) {
_buildFile.text.readLines()
Expand Down
Loading