Skip to content

fix: stop adding trailing / to absolute urls - #48

Merged
5ZYSZ3K merged 1 commit into
mainfrom
fix/normalize-resource-locator-trailing-slash
Sep 22, 2026
Merged

5ZYSZ3K merged 1 commit into
mainfrom
fix/normalize-resource-locator-trailing-slash

Conversation

@5ZYSZ3K

@5ZYSZ3K 5ZYSZ3K commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Closes #47

@5ZYSZ3K
5ZYSZ3K requested a review from jsamr July 24, 2026 16:32
@5ZYSZ3K 5ZYSZ3K self-assigned this Jul 24, 2026
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.65%. Comparing base (b3cea89) to head (2ee4cdb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   98.65%   98.65%           
=======================================
  Files         140      140           
  Lines        2085     2088    +3     
  Branches      635      640    +5     
=======================================
+ Hits         2057     2060    +3     
  Misses         27       27           
  Partials        1        1           
Flag Coverage Δ
css-processor 100.00% <ø> (ø)
render 97.85% <100.00%> (+<0.01%) ⬆️
transient-render-engine 98.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@InkaAlicja InkaAlicja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. On thing to note is that this was fixed in newer rn react/react-native@1e06c92

@5ZYSZ3K

5ZYSZ3K commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

@jsamr I added and asked @InkaAlicja for a review here (I need an approval from someone with write permissions anyway), she's a co-worker in my current project

@5ZYSZ3K
5ZYSZ3K merged commit 40612ca into main Sep 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

normalizeResourceLocator mangles absolute URLs by appending a trailing slash, breaking <a href> links

2 participants