Skip to content

Potential fixes for 5 code quality findings #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahosgood merged 5 commits into from
Apr 17, 2026
Merged

Potential fixes for 5 code quality findings #27

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9efa009
Apply suggested fix to tests/test_api.py from Copilot Autofix
ahosgood Apr 17, 2026
1700fe7
Apply suggested fix to tests/test_api.py from Copilot Autofix
ahosgood Apr 17, 2026
232147f
Apply suggested fix to tests/test_api.py from Copilot Autofix
ahosgood Apr 17, 2026
3280c82
Apply suggested fix to tests/test_api.py from Copilot Autofix
ahosgood Apr 17, 2026
f4805a0
Apply suggested fix to tests/test_api.py from Copilot Autofix
ahosgood Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,36 +99,36 @@ def test_resource_unauthorized(self, mock_post, mock_get):

@mock.patch("requests.get", side_effect=mocked_requests_get)
@mock.patch("requests.post", side_effect=mocked_requests_post)
def test_resource_forbidden(self, mock_get, mock_post):
def test_resource_forbidden(self, mock_post, mock_get):
client = SimpleJsonApiClient(MOCK_API_BASE_URL)
with self.assertRaises(ResourceForbidden):
client.get("/forbidden")

@mock.patch("requests.get", side_effect=mocked_requests_get)
@mock.patch("requests.post", side_effect=mocked_requests_post)
def test_resource_timeout(self, mock_get, mock_post):
def test_resource_timeout(self, mock_post, mock_get):
client = SimpleJsonApiClient(MOCK_API_BASE_URL)
with self.assertRaises(Timeout):
client.get("/timeout")

@mock.patch("requests.get", side_effect=mocked_requests_get)
@mock.patch("requests.post", side_effect=mocked_requests_post)
def test_other_exception(self, mock_get, mock_post):
def test_other_exception(self, mock_post, mock_get):
client = SimpleJsonApiClient(MOCK_API_BASE_URL)
with self.assertRaises(Exception):
client.get("/servererror")

@mock.patch("requests.get", side_effect=mocked_requests_get)
@mock.patch("requests.post", side_effect=mocked_requests_post)
def test_post(self, mock_get, mock_post):
def test_post(self, mock_post, mock_get):
client = SimpleJsonApiClient(MOCK_API_BASE_URL)
response = client.post("/post", data={"foo": "bar"})
self.assertEqual(type(response), dict)
self.assertDictEqual(response, {"response": "success"})

@mock.patch("requests.get", side_effect=mocked_requests_get)
@mock.patch("requests.post", side_effect=mocked_requests_post)
def test_post_json(self, mock_get, mock_post):
def test_post_json(self, mock_post, mock_get):
client = SimpleJsonApiClient(MOCK_API_BASE_URL)
response = client.post("/post", json=json.dumps({"foo": "bar"}))
self.assertEqual(type(response), dict)
Expand Down
Loading