Skip to content

Potential fixes for 5 code quality findings #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahosgood merged 7 commits into from
Apr 17, 2026
Merged

Potential fixes for 5 code quality findings #26

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0448aa3
Apply suggested fix to tna_utilities/api.py from Copilot Autofix
ahosgood Apr 17, 2026
b6af31e
Apply suggested fix to tna_utilities/api.py from Copilot Autofix
ahosgood Apr 17, 2026
d059e86
Apply suggested fix to tna_utilities/api.py from Copilot Autofix
ahosgood Apr 17, 2026
4ae3875
Apply suggested fix to tna_utilities/api.py from Copilot Autofix
ahosgood Apr 17, 2026
2399cbd
Apply suggested fix to tna_utilities/api.py from Copilot Autofix
ahosgood Apr 17, 2026
250c7e9
Merge branch 'main' into ai-findings-autofix/tna_utilities-api.py
ahosgood Apr 17, 2026
668de4f
Refactor error handling in SimpleJsonApiClient to simplify exception …
ahosgood Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions tna_utilities/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,10 @@ def get(
:param params: Optional dictionary of query parameters to include in the request. These will be merged with any default parameters set for the client.
:param headers: Optional dictionary of headers to include in the request. These will be merged with any default headers set for the client.
:param timeout: Timeout in seconds for the request. Defaults to 10.
:raises ResourceNotFound: If the requested resource is not found (HTTP 404).
:raises ResourceForbidden: If access to the resource is forbidden (HTTP 403).
:raises ResourceUnauthorized: If authentication is required or has failed (HTTP 401).
:raises Exception: For unexpected response handling or request-processing errors.
"""

url = self._normalise_url(path)
Expand Down Expand Up @@ -129,6 +133,10 @@ def post(
:param params: Optional dictionary of query parameters to include in the request. These will be merged with any default parameters set for the client.
:param headers: Optional dictionary of headers to include in the request. These will be merged with any default headers set for the client.
:param timeout: Request timeout in seconds.
:raises ResourceNotFound: If the requested resource is not found (HTTP 404).
:raises ResourceForbidden: If access to the resource is forbidden (HTTP 403).
:raises ResourceUnauthorized: If authentication is required or has failed (HTTP 401).
:raises Exception: For other non-success responses or unexpected response handling errors.
"""

url = self._normalise_url(path)
Expand All @@ -151,16 +159,13 @@ def _handle_response(self, response: Response) -> dict:
try:
return response.json()
except JSONDecodeError:
raise Exception(
f"Non-JSON response provided for URL {response.url} "
f"with status {response.status_code}"
)
raise Exception("Non-JSON response provided")
if response.status_code == 400:
try:
error_body = response.json()
except JSONDecodeError:
error_body = response.text
raise Exception(f"Bad request for URL '{response.url}': {error_body}")
raise Exception(f"Bad request: {error_body}")
if response.status_code == 401:
raise ResourceUnauthorized("Unauthorized")
if response.status_code == 403:
Expand Down
Loading