Skip to content

Potential fixes for 2 code quality findings #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahosgood merged 3 commits into from
Apr 17, 2026
Merged

Potential fixes for 2 code quality findings #25

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5872552
Apply suggested fix to tna_utilities/flask/talisman.py from Copilot A…
ahosgood Apr 17, 2026
04937c4
Apply suggested fix to tna_utilities/flask/talisman.py from Copilot A…
ahosgood Apr 17, 2026
388b501
Merge branch 'main' into ai-findings-autofix/tna_utilities-flask-tali…
ahosgood Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions tna_utilities/flask/talisman.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def init_app(
SESSION_COOKIE_SECURE=force_https and not self.app.debug,
SESSION_COOKIE_HTTPONLY=True,
SESSION_COOKIE_SAMESITE="Lax",
PERMANENT_SESSION_LIFETIME=86400, # 1 day
PERMANENT_SESSION_LIFETIME=60 * 60 * 24, # 1 day
)

self.content_security_policy = content_security_policy
Expand Down Expand Up @@ -118,8 +118,16 @@ def _force_https_redirect(self):
if self.force_https and not any(criteria):
if flask.request.url.startswith("http://"):
parsed = urlparse(flask.request.url)
secure_parsed = parsed._replace(scheme="https", fragment="")
target = urlunparse(secure_parsed)
target = urlunparse(
(
"https",
parsed.netloc,
parsed.path,
parsed.params,
parsed.query,
"",
)
)
code = 302
if self.force_https_permanent:
code = 301
Expand Down
Loading