Skip to content

Potential fixes for 5 code quality findings #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahosgood merged 5 commits into from
Apr 17, 2026
Merged

Potential fixes for 5 code quality findings #21

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64ff3d2
Apply suggested fix to tests/test_api.py from Copilot Autofix
ahosgood Apr 17, 2026
1936fc5
Apply suggested fix to tests/test_api.py from Copilot Autofix
ahosgood Apr 17, 2026
26e0158
Apply suggested fix to tests/test_api.py from Copilot Autofix
ahosgood Apr 17, 2026
970d822
Apply suggested fix to tests/test_api.py from Copilot Autofix
ahosgood Apr 17, 2026
19b82af
Apply suggested fix to tests/test_api.py from Copilot Autofix
ahosgood Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions tests/test_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,14 @@
def mocked_requests_get(*args, **kwargs):
class MockResponse:
def __init__(
self, json_data: dict | None, status_code: int, headers: dict = {}
self,
json_data: dict | None,
status_code: int,
headers: dict | None = None,
):
self.json_data = json_data
self.status_code = status_code
self.headers = headers
self.headers = headers if headers is not None else {}

def json(self):
return self.json_data
Expand Down Expand Up @@ -67,29 +70,29 @@ def json(self):
class TestSimpleJsonApiClient(TestCase):
@mock.patch("requests.get", side_effect=mocked_requests_get)
@mock.patch("requests.post", side_effect=mocked_requests_post)
def test_happy(self, mock_get, mock_post):
def test_happy(self, mock_post, mock_get):
client = SimpleJsonApiClient(MOCK_API_BASE_URL)
response = client.get("/happy")
self.assertEqual(type(response), dict)
self.assertDictEqual(response, {"foo": "bar"})

@mock.patch("requests.get", side_effect=mocked_requests_get)
@mock.patch("requests.post", side_effect=mocked_requests_post)
def test_bad_request(self, mock_get, mock_post):
def test_bad_request(self, mock_post, mock_get):
client = SimpleJsonApiClient(MOCK_API_BASE_URL)
with self.assertRaises(Exception):
client.get("/badrequest")

@mock.patch("requests.get", side_effect=mocked_requests_get)
@mock.patch("requests.post", side_effect=mocked_requests_post)
def test_not_found(self, mock_get, mock_post):
def test_not_found(self, mock_post, mock_get):
client = SimpleJsonApiClient(MOCK_API_BASE_URL)
with self.assertRaises(ResourceNotFound):
client.get("/notfound")

@mock.patch("requests.get", side_effect=mocked_requests_get)
@mock.patch("requests.post", side_effect=mocked_requests_post)
def test_resource_unauthorized(self, mock_get, mock_post):
def test_resource_unauthorized(self, mock_post, mock_get):
client = SimpleJsonApiClient(MOCK_API_BASE_URL)
with self.assertRaises(ResourceUnauthorized):
client.get("/unauthorized")
Expand Down
Loading