Skip to content

Potential fixes for 2 code quality findings #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahosgood merged 3 commits into from
Apr 17, 2026
Merged

Potential fixes for 2 code quality findings #20

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61e90c8
Apply suggested fix to tna_utilities/api.py from Copilot Autofix
ahosgood Apr 17, 2026
ed58b0c
Apply suggested fix to tna_utilities/api.py from Copilot Autofix
ahosgood Apr 17, 2026
3afb244
Merge branch 'main' into ai-findings-autofix/tna_utilities-api.py
ahosgood Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tna_utilities/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,15 +151,18 @@ def _handle_response(self, response: Response) -> dict:
try:
return response.json()
except JSONDecodeError:
raise Exception("Non-JSON response provided")
raise Exception(
f"Non-JSON response provided for URL {response.url} "
f"with status {response.status_code}"
)
if response.status_code == 400:
try:
error_body = response.json()
except JSONDecodeError:
error_body = response.text
raise Exception(f"Bad request for URL '{response.url}': {error_body}")
if response.status_code == 401:
raise ResourceUnauthorized("Unauthorised")
raise ResourceUnauthorized("Unauthorized")
if response.status_code == 403:
raise ResourceForbidden("Forbidden")
if response.status_code == 404:
Expand Down
Loading